-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic Filter: Wired - Hide empty flash ad frame in footer of all posts #28
Comments
pr coming soon. trying to include checksum update as well. |
I don't see that empty placeholder on my side. Anyways, the rule is way too complicated. I guess it's what uBO offered, but no filter list maintainers would come up with such a rule. Other point, as said last time, no need to open an issue separate from the pull request, the pull request itself can be documented just as well. |
Ok. Gotchya. I was thinking that I should still create an issue but it would be automatically created during the pr process, but I couldn't get that to work. Won't submit issues prior to prs in the future. Thanks. |
I still would like to understand how you ended up with a placeholder at that position, as said I can't see this on my side. You say "Flash ad frame", but your picture is that of an |
@gorhill hmm, ok, I am still trying to learn how to inspect, etc. Here's a capture in Chrome on Mac with both uBlock Origin and Reek's anti-adblocker script disabled. Maybe it's just an unsold ad space? I'm not sure. I see it in Safari on Mac, too. |
The iframe src is |
So, the logger reports the following:
There is no visible ad showing up, but without the complex rule that the UBO picker generates, the html frame around where the ad should go is still visible. The rule, copied again below, hides the entire frame (not sure if "frame" is the right word).
|
@okiehsch , interesting. thanks! hmm... when filtering for that in logger, this is what I see. What is the order of operations in which the rules are applied? is one of the green rules overriding the red rule? |
oh, oops, you specified it was the show_ads.js which does have an allow rule applied. the allow rule is coming from Fanboy+Easylist-Merged Ultimate List. I'll have to dig around their forums and see why that is allowed. Thanks. |
ok, it's being allowed by that list in the following block. is there a way I can temporarily override that one rule from the list?
|
So it's possibly rules for ABP to work around Wired's anti blocker scheme? In that case, they should be overridden for the sake of uBO's users. Can you try:
Update: Paradoxically, these exception filters are in Fanboy's Enhanced Tracking List -- I don't understand what their purpose are. |
@gorhill yep, adding those rules fixes it. this is the only rule that seems to be needed for the specific issue I'm seeing. ||pagead2.googlesyndication.com/pagead/show_ads.js$important,domain=wired.com |
We need to find out why this exception filter was added. |
Was added because of the Anti-adblock stuff, has the requirement for this rule changed? |
If you use Adblock Plus The exception filter |
Restored blocking filters using the |
One or more specific URLs where the issue occurs
http://www.wired.com/2016/04/average-webpage-now-size-original-doom/
Describe the issue
There is an empty flash ad frame at the bottom left corner of all (or at least a decent sized sample I just tested) posts on Wired.
Screenshot(s)
Your settings
The text was updated successfully, but these errors were encountered: