Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic filter creation for advanced users #1058

Closed
4 of 8 tasks
Ro-Den opened this issue May 20, 2020 · 1 comment
Closed
4 of 8 tasks

Automatic filter creation for advanced users #1058

Ro-Den opened this issue May 20, 2020 · 1 comment
Labels
declined declined enhancement New feature or request

Comments

@Ro-Den
Copy link

Ro-Den commented May 20, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Is it possible to add automatic filter creation? Like, auto-clicking "Create' on specified domains. For advanced users only, of course.

A specific URL where the issue occurs

Any domain specified by the user in Advanced settings.

Steps to Reproduce

  1. Right-click
  2. Click "Block element..."
  3. Click "Create"

Expected behavior:

if ( bestCandidateFilter !== null && window.location.hostname.includes('.example.com') ) {
    onDialogClicked('create');
}

Actual behavior:

One has to click "Create" all the time even if the bestCandidateFilter is really the best one and always the best one in a particular domain.

Your environment

  • uBlock Origin version: 1.27
  • Browser Name and version: Mozilla Firefox Quantum 68.8.0 ESR (64-bit)
  • Operating System and version: Linux Kubuntu 20.04
@uBlock-user uBlock-user added the enhancement New feature or request label May 20, 2020
@gorhill gorhill added the declined declined label May 20, 2020
@gorhill
Copy link
Member

gorhill commented May 20, 2020

I don't see this as a good idea, the picker is a tool to assist filter creation, it's not to be used as a tool to make final decision on behalf of user.

@gorhill gorhill closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants