Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"My filters" displayed filters and actually used filters can be different in some cases (timing issue when saving?). #1355

Open
8 tasks done
gwarser opened this issue Nov 21, 2020 · 3 comments
Labels
something to address something to address

Comments

@gwarser
Copy link
Member

gwarser commented Nov 21, 2020

Details

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

After saving filter A in normal window and filter B in incognito, uBO will show filter A in My filters, but apply filter B.

A specific URL where the issue occurs

internal

Steps to Reproduce

  1. Open Dashboard in normal window and type example.com in My filters
  2. Open Dashboard in Incognito window and type example.net in My filter
  3. Switch to normal window
  4. Save filter in normal window by Ctrl+S
  5. Quickly switch to Incognito window (place mouse cursor over it on taskbar before previous point to make it faster)
  6. Save filter in Incognito window by Ctrl+S
  7. Refresh dashboard in both widows

Expected behavior:

  • Last filter win OR
  • Both windows have it's own filter saved
  • Filters work as expected when "example" pages opened in new tabs

Actual behavior:

  • Incognito window keeps .net filter
  • Normal window My filters editor updates to .net filter (after Dashboard was refreshed)
  • .net filter is applied in Incognito window when tried in new page
  • Normal window applies .com filter despite .net being visible in My filters

Your environment

  • uBlock Origin version: 1.30.6, 1.32.5b3
  • Browser Name and version: Chrome Version 87.0.4280.66 (Official Build) (64-bit)
  • Operating System and version: Manjaro KDE

Notes:

First experienced here: https://www.reddit.com/r/uBlockOrigin/comments/jh6ec3/site_breaking_seemingly_without_adblock/ga1lstj/

@gwarser gwarser changed the title uBO can confuse main and incognito storage in specific cases. uBO can confuse main and incognito storage in specific cases (timing issue when saving?). Nov 21, 2020
@uBlock-user uBlock-user added the something to address something to address label Nov 23, 2020
@gorhill
Copy link
Member

gorhill commented Jan 2, 2021

confuse main and incognito storage

There is only one storage for both normal and incognito. Both instances of uBO uses the same storage.

@gwarser gwarser changed the title uBO can confuse main and incognito storage in specific cases (timing issue when saving?). "My filters" displayed filters and actually used filters can be different in some cases (timing issue when saving?). Jan 2, 2021
@gwarser
Copy link
Member Author

gwarser commented May 15, 2021

https://www.reddit.com/r/uBlockOrigin/comments/nb8fml/possible_buginconsistency_with_incognito_mode_and/ ?

@realdimas
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
something to address something to address
Projects
None yet
Development

No branches or pull requests

5 participants
@gorhill @gwarser @realdimas @uBlock-user and others