Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when trying to use element picker on plaintext resource #1675

Closed
8 tasks done
vtriolet opened this issue Jul 31, 2021 · 0 comments
Closed
8 tasks done

TypeError when trying to use element picker on plaintext resource #1675

vtriolet opened this issue Jul 31, 2021 · 0 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@vtriolet
Copy link

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

A TypeError is triggered when you try to use the element picker on a plaintext resource.

Firefox:

TypeError: vAPI is undefined epicker.js:33:19

Chrome:

Uncaught (in promise) TypeError: Cannot read property 'randomToken' of undefined
    at VM11 epicker.js:33
    at VM11 epicker.js:1294

A specific URL where the issue occurs

https://www.google.com/robots.txt

Steps to Reproduce

  1. Navigate to https://www.google.com/robots.txt
  2. Right-click on the page and select 'Block element...' to trigger a TypeError

Expected behavior

I'm not sure if the element picker can work with plaintext resources, but it seems desirable to at least avoid the TypeError.

Actual behavior

A TypeError is triggered.

uBlock Origin version

1.37.2

Browser name and version

Firefox 90.0.2, Chrome 92.0.4515.107

Operating System and version

Arch Linux

@uBlock-user uBlock-user added the bug Something isn't working label Jul 31, 2021
@uBlock-user uBlock-user added the fixed issue has been addressed label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

2 participants