Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible without codemirror? [ease of access][♿] #1720

Closed
8 tasks done
ghost opened this issue Sep 13, 2021 · 4 comments
Closed
8 tasks done

possible without codemirror? [ease of access][♿] #1720

ghost opened this issue Sep 13, 2021 · 4 comments
Labels
something to address something to address

Comments

@ghost
Copy link

ghost commented Sep 13, 2021

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

My DPI definition is about 150%,
uBlock origin uses codemirror which wraps the textarea with native elements such as span and div to present colors (and in some cases pseudo elements, shadowdom elements and CSS-content), which not always scale correctly and doing horrible with screen-readers,
and the current color scheme (especially red and green over white) is somewhat challenging to read.

plus, and that is not the main issue here, codemirror for highlighting tries to match "-characters, which is a fine feature overall to rule-out typos. but it acts up when copying parts of the rules and then editing it (adding undeletable pair-characters and such).

this, along with the scale problem explained earlier makes the mouse unusable,
pointing it to the end of the line, places the mouse cursor few lines below.
so trying to fix the issue with mouse is impossible.
I was using the keyboard to navigate, but even HOME and END navigation ended up buggy! I've ended up CTRL+A, cutting, pasting in Notepad++, editing, and copying pasting back, I also had to use cut and save the empty rule set, so pasting the content from Notepad++ will be identified correctly as a changed content.

ublock_origin_issue_1720.mp4

https://streamable.com/wn2t6p

I would like please an option in uBlock for using plain old textarea,
in developer terms, a possibility to skip the codemirror initializing (where you specify the textarea object target).
with as few minimal styling as possible!
monospace, plain black/white text, no kerning, no custom font (default UI font)

Thanks!

A specific URL where the issue occurs

chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#1p-filters.html

Steps to Reproduce

  1. you do not need screen reader nor to set your operation system for higher DPI,
    use --force-device-scale-factor="1.65". in your Chrome-based browser.
    for Firefox use about:config, layout.css.devPixelsPerPx set to 1.8 (can be string). but Firefox is less buggy.
  2. browse various configuration-pages.
  3. profit! (not really, you'll just do some kindness to your uBlockOrigin users..)

Expected behavior

option to disable all codemirror behaviour.

Actual behavior

UI navigation glitches using pointing device in high dpi.

uBlock Origin version

1.37.2

Browser name and version

Chromium Version 91.0.4472.124 (Official Build) (64-bit)

Operating System and version

Microsoft Windows [Version 10.0.19044.1165] - 10 x64.

@gwarser gwarser added the something to address something to address label Sep 13, 2021
@liskaaaaaaaaaa

This comment has been minimized.

@krystian3w

This comment has been minimized.

@krystian3w

This comment has been minimized.

@uBlockOrigin uBlockOrigin locked as off-topic and limited conversation to collaborators Sep 22, 2021
@uBlockOrigin uBlockOrigin unlocked this conversation Sep 22, 2021
@gorhill

This comment has been minimized.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
something to address something to address
Projects
None yet
Development

No branches or pull requests

4 participants