Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key frequently not working in zapper mode #174

Closed
5 of 8 tasks
tamlin-mike opened this issue Aug 19, 2018 · 1 comment
Closed
5 of 8 tasks

Delete key frequently not working in zapper mode #174

tamlin-mike opened this issue Aug 19, 2018 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@tamlin-mike
Copy link

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

[Description of the bug or feature]
This is my follow-up to #3631. I have repro sites, but due to the change in who could add comments (only code contributors) I was prevented from adding that (probably vital) info to the bug report.

A specific URL where the issue occurs

https://www.svd.se/

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [First Step]
    Visit site. Noteworthy might be I do have a bunch of UO hiding rules already in effect. I also have NoScript active.
  2. [Second Step]
    Select UP Element Zapper icon inside the UO pop-down "menu".
  3. [and so on...]
    Use mouse to move around. Note that it highlights page elements as you move the cursor over them. Hit the Del(ete) key, and note how nothing happens. Workaround I found seems to be you need to right-click, to bring up the context menu, then hit ESC to dismiss it. Now the Del key works as expected.

Expected behavior:

Del(ete) key works immediately on entering zapping mode.

[What you expected to happen]

Actual behavior:

Already explained.

[What actually happened]
Already explained.

Your environment

  • uBlock Origin version: 1.16.16
  • Browser Name and version: Firefox.Q 61.0.2 64-bit
  • Operating System and version: Win10-64
@gwarser
Copy link
Member

gwarser commented Aug 19, 2018

Different repository gorhill/uBlock#3631

Duplicate of gorhill/uBlock#953

gorhill/uBlock#953 (comment):

Maybe something else is "eating" the Esc key, preventing the event from reaching uBO. Something to try when this occurs: right-click on the page to bring up the contextual menu, then right click again somewhere on the page to dismiss the contextual menu, then try again the Esc key. Does it works now?

Can you check Nightly? gorhill/uBlock#3631 (comment)

@gwarser gwarser closed this as completed Aug 19, 2018
@gwarser gwarser changed the title Follow-up to #3631 Follow-up to #3631 (Delete key frequently not working in zapper mode) Aug 19, 2018
@gwarser gwarser added duplicate This issue or pull request already exists Firefox specific to Firefox labels Aug 19, 2018
@uBlock-user uBlock-user changed the title Follow-up to #3631 (Delete key frequently not working in zapper mode) Delete key frequently not working in zapper mode Aug 19, 2018
@uBlock-user uBlock-user removed the Firefox specific to Firefox label Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants