Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember and reuse last position/size of the logger popup window #256

Closed
MS-PC opened this issue Oct 6, 2018 · 10 comments
Closed

Remember and reuse last position/size of the logger popup window #256

MS-PC opened this issue Oct 6, 2018 · 10 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@MS-PC
Copy link

MS-PC commented Oct 6, 2018

I was wondering if you can also set in the logger window in maximized just like Firefox. Since it is uncomfortable to maximize the logger window every time. Since the window is small, and does not show much. It's just a suggestion.

@uBlock-user uBlock-user added the enhancement New feature or request label Oct 6, 2018
@gorhill
Copy link
Member

gorhill commented Oct 6, 2018

The browser set the size of the logger window, I prefer to keep it this way.

@gorhill gorhill added the declined declined label Oct 6, 2018
@gorhill gorhill closed this as completed Oct 6, 2018
@gorhill
Copy link
Member

gorhill commented Oct 6, 2018

Actually, what I could try to do (need experimentation) is to restore the position/size of the logger popup window that last time it was used.

Logger window maximized just like Firefox

Just to be clear, uBO does not maximize the window, it's the browser doing this on your side, it's not happening on my side -- there is no code in uBO to modify the window size.

@gorhill gorhill reopened this Oct 6, 2018
@gorhill gorhill removed the declined declined label Oct 6, 2018
@krystian3w
Copy link

krystian3w commented Oct 8, 2018

For me, the uBO / Firefox did not remember the width of the window (he always start as very thin window - one quarter of the window that has been maximally opened) and only after refreshing the profile in Firefox and reinstalling the uBO helped.

@gorhill gorhill changed the title Logger window maximized just like Firefox (Opera browser) Remember and reuse last position/size of the logger popup window Dec 14, 2018
@uBlock-user uBlock-user added the fixed issue has been addressed label Dec 14, 2018
@gorhill
Copy link
Member

gorhill commented Dec 18, 2018

Unfortunately it does not work perfectly with Chromium, the restored position is a bit offset from what it was last time -- well at least this is what I observe on linux, and the offset seems to match the window decoration thickness. It seems Chromium is not returning to proper value in chrome.window.get() for the left and top position -- I consider this a browser issue. The same code work fine with Firefox.

@gwarser
Copy link
Member

gwarser commented Dec 19, 2018

In Firefox, when title bar is disabled, if I close main window and then logger, on next start logger window is also without title bar.

image

It's OK on stable, because buttons in top right corner are still visible, but on beta and Nightly they sometimes disappear.

image

@gwarser
Copy link
Member

gwarser commented Dec 19, 2018

Hmmm. This is not about Firefox stable/beta, but uBO stable/dev

@gorhill
Copy link
Member

gorhill commented Dec 19, 2018

How do you disable the title bar?

@gwarser
Copy link
Member

gwarser commented Dec 19, 2018

Right click on toolbar, select "Customize", in new tab bottom left corner.

@gorhill
Copy link
Member

gorhill commented Dec 19, 2018

on next start logger window is also without title bar

I can reproduce. However, isn't this a Firefox issue? uBO is not opening the logger at launch, it's Firefox's session manager doing this.

@krystian3w
Copy link

Try recover session Firefox with opened logger, for my side comeback uBO logger as maximalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

5 participants