Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ublock Origin not blocking ads on Crunchyroll on Google Chrome 76 #689

Closed
8 tasks done
Rihcus opened this issue Aug 5, 2019 · 30 comments
Closed
8 tasks done

Ublock Origin not blocking ads on Crunchyroll on Google Chrome 76 #689

Rihcus opened this issue Aug 5, 2019 · 30 comments
Labels
Chromium specific to Chromium/Chrome filterlist a filter list issue invalid not a uBlock issue unable to reproduce cannot reproduce the issue

Comments

@Rihcus
Copy link

Rihcus commented Aug 5, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Ublock Origen doesn't to seem to be working on sites like Crunchyroll on Chrome 76. I had the same issue on on older versions of chrome but fixed it by disabling feature under chrome://flags called "Enable Network service" now on chrome 76 this option has been removed.

More info about "Enable Network service"
https://www.quora.com/What-does-enable-network-service-do-in-Google-Chrome-flags-Are-there-repercussions-for-disabling-it

[Description of the bug or feature]

A specific URL where the issue occurs

http://crunchyroll.com

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [Open http://crunchyroll.com on Chrome 76]
  2. [Play a video and ads apear]
  3. [and so on...]

Expected behavior:

I expected for block to block the ads and it didn't due to the Chrome 76 forces "Enable Network Service"
[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

I run Chrome 76 both on windows and Mac with ublock Origen. Both where blocking perfectly on chrome 75 but upon update to chrome 76 blocking on Crunchyroll failed.

  • uBlock Origin version: v1.21.6
  • Browser Name and version: Google Chrome Version 76.0.3809.87 (Official Build) (64-bit)
  • Operating System and version: Mac OS Mojave and Windows 10
@gwarser
Copy link
Member

gwarser commented Aug 5, 2019

crunchyroll.com##+js(setInterval-defuser, onAdVideoStart) does not work for you? uBlockOrigin/uAssets#1279 (comment)

Are you /u/NeverForgetChainRule? https://www.reddit.com/r/uBlockOrigin/comments/ckgp74/crunchyroll_ads_getting_through_again/

@uBlock-user ?

@uBlock-user uBlock-user added the unable to reproduce cannot reproduce the issue label Aug 5, 2019
@uBlock-user
Copy link
Contributor

uBlock-user commented Aug 5, 2019

Tested on https://www.crunchyroll.com/boruto-naruto-next-generations/episode-117-remons-secret-786485

no ads appear!

@Rihcus
Copy link
Author

Rihcus commented Aug 5, 2019

Tested on https://www.crunchyroll.com/boruto-naruto-next-generations/episode-117-remons-secret-786485

no ads appear!

Did you update to chrome 76? I did it manually It was working on 75. I tested it on stock settings and reset my entire browser still ads are coming through

@uBlock-user
Copy link
Contributor

Did you update to chrome 76?

tested on 76 and the current canary version 78, no ads, if I disable the filter, then only I see the video ad.

@uBlock-user
Copy link
Contributor

Will need somebody else to report for feedback here -- @okiehsch

@uBlock-user uBlock-user added the something to address something to address label Aug 5, 2019
@gwarser
Copy link
Member

gwarser commented Aug 5, 2019

At first I had problems with playing at all with this one https://www.crunchyroll.com/gegege-no-kitaro/episode-66-the-shinigami-and-sakaiminatos-hidden-village-786498 (does not start?) and "start a free trial today!" https://www.crunchyroll.com/to-the-abandoned-sacred-beasts/episode-6-the-king-of-the-beasts-786831, but I tried few other videos, and all seems to work exactly the same on 75 and 77 without any ad.

So... Maybe it's something with your config @Rihcus ? Or problem on 76 only?


I tested it on stock settings and reset my entire browser still ads are coming through

Hmmm...

@gorhill
Copy link
Member

gorhill commented Aug 5, 2019

Unless there is actual evidences that something is wrong in uBO, this has to be assumed a filter issue.

@okiehsch
Copy link

okiehsch commented Aug 5, 2019

I can't reproduce any pre-roll ads.

At first I had problems with playing at all with this one https://www.crunchyroll.com/gegege-no-kitaro/episode-66-the-shinigami-and-sakaiminatos-hidden-village-786498 (does not start?)

That video will not start even if I disable uBO.

@gwarser gwarser removed the something to address something to address label Aug 5, 2019
@gwarser
Copy link
Member

gwarser commented Aug 5, 2019

@Rihcus more data? Link to video? Maybe regional list?

@uBlock-user uBlock-user added the filterlist a filter list issue label Aug 5, 2019
@uBlock-user uBlock-user added the invalid not a uBlock issue label Aug 5, 2019
@Rihcus
Copy link
Author

Rihcus commented Aug 6, 2019

So the weird thing I find with the crunchy roll ads are they are all "xxx anime streaming on Crunchyroll now". Anyhow I completely uninstalled (deleted all app data) and reinstalled chrome and installed Ublock Origen with stock filters and am still getting ads.

I then tried to run chrome canary Version 78.0.3874.3 (Official Build) canary (64-bit) stock no sync and I still get ads from any Crunchyroll video.

I tried to run the same stock setting on Ublock Origen on safari and didn't have any ads. (I know the safari is a fork).

Idk if this helps but this the logs I got from Version 76.0.3809.87 (Official Build) (64-bit)
when running this video https://www.crunchyroll.com/dr-stone/episode-4-fire-the-smoke-signal-786944

https://pastebin.com/raw/SXYwVUym

The safari version of Ublock Origen was uBlock Origin v1.16.0

All I know is so far when chrome://flags/#network-service was disabled Cr's ads stopped when the option to disable the feature was removed the ads came back.

@okiehsch
Copy link

okiehsch commented Aug 6, 2019

Your log does not show the filter
crunchyroll.com##+js(setInterval-defuser, onAdVideoStart)
There are some known issues with script-injections using MacOS, do you have the same issue with Windows 10?
I have no issues at Crunchyroll using Windows 10 or Linux.

@uBlock-user uBlock-user changed the title Ublock Origen not blocking ads on Crunchyroll on Google Chrome 76 Ublock Origin not blocking ads on Crunchyroll on Google Chrome 76 Aug 6, 2019
@gorhill
Copy link
Member

gorhill commented Aug 6, 2019

I went through the various video links published above and this is what I get with Chromium 76:

  • Playback fails, without ads:
    • https://www.crunchyroll.com/en-gb/boruto-naruto-next-generations/episode-117-remons-secret-786485
    • https://www.crunchyroll.com/en-gb/gegege-no-kitaro/episode-66-the-shinigami-and-sakaiminatos-hidden-village-786498
    • https://www.crunchyroll.com/en-gb/dr-stone/episode-4-fire-the-smoke-signal-786944
  • Playback works, without ads:
    • https://www.crunchyroll.com/en-gb/to-the-abandoned-sacred-beasts/episode-6-the-king-of-the-beasts-786831

After I disabled uBO in chrome://extensions/:

  • Playback still fails, with a preroll ad:
    • https://www.crunchyroll.com/en-gb/boruto-naruto-next-generations/episode-117-remons-secret-786485
    • https://www.crunchyroll.com/en-gb/gegege-no-kitaro/episode-66-the-shinigami-and-sakaiminatos-hidden-village-786498
  • Playback works, without ads:
    • https://www.crunchyroll.com/en-gb/to-the-abandoned-sacred-beasts/episode-6-the-king-of-the-beasts-786831

So it seems the site has an issue in the first place, it fails to play some videos, those which appears to require a pre-roll ad, even when uBO is wholly disabled (in which case the ad plays).

I tried with both AdGuard and ABP, and the broken playback issue is also occurring, except that this time the pre-roll ads are played.

@gorhill
Copy link
Member

gorhill commented Aug 6, 2019

By the way, all the videos above played fine with no pre-roll ads in Firefox 68/uBO 1.21.2.

@Rihcus
Copy link
Author

Rihcus commented Aug 6, 2019

Your log does not show the filter
crunchyroll.com##+js(setInterval-defuser, onAdVideoStart)
There are some known issues with script-injections using MacOS, do you have the same issue with Windows 10?
I have no issues at Crunchyroll using Windows 10 or Linux.

I tested ublock origin on a clean install of chrome Version 76.0.3809.87 (Official Build) (64-bit) on windows 10 with stock settings and still get preroll ads. Here are the logs:
https://pastebin.com/raw/m79UR4iG

I tried running Firefox version 68.0.1 on windows 10 with uBlock Origin v1.21.2 (just downloaded from the Firefox store today) and I get no ads. Here are the logs Firefox uBlock Origin.
https://pastebin.com/raw/kWMn3UwU

I used this video to test
https://www.crunchyroll.com/dr-stone/episode-4-fire-the-smoke-signal-786944

Some times the blocker worked but if go back to episode 3 and 2 then go back to 4 I will start get ads.

@gwarser
Copy link
Member

gwarser commented Aug 7, 2019

Updated to Version 76.0.3809.100 (Official Build) (64-bit) and cannot reproduce.

@dumbusernameidk
Copy link

dumbusernameidk commented Aug 8, 2019

I get an ad on this video https://www.crunchyroll.com/isekai-cheat-magician/episode-1-lost-ones-from-another-world-787185 using Chrome V76 and default filter lists. The filter crunchyroll.com##+js(setInterval-defuser, onAdVideoStart) doesn't seem to work. Maybe the ads are only specific to certain regions? I'm in the US if that helps.

@kamilion
Copy link

kamilion commented Aug 8, 2019

I just restarted chrome to get on 76, and hit this just now. US/Silicon Valley.
Logged in to an account that had previously been premium.
Tried to watch:
https://www.crunchyroll.com/if-its-for-my-daughter-id-even-defeat-a-demon-lord/episode-4-the-little-girl-and-the-incident-786961

ublock nor umatrix sees any request to static.vrv.co/houseads/
If I launch the inspector and turn on request blocking of static.vrv.co from there, I get a couple console log entries.
Console Log:
www.crunchyroll.com-1565240378415.log
uBlock Origin Logger:
www.crunchyroll.com-1565240378415-ublock.log

Somehow their requests are bypassing the filter hooks, as I don't see any references to vrv.co at all in umatrix or ublock origin's advanced view.

Happened before around aprilish, I added https://static.vrv.co/houseads/* to the devtools blocker around then, but it's only active while the inspector is open. Somehow it catches and kills the request though.

@uBlock-user
Copy link
Contributor

Somehow their requests are bypassing the filter hooks, as I don't see any references to vrv.co at all in umatrix or ublock origin's advanced view.

CR does make use of Application Cache, so probably related to that.

@Rihcus
Copy link
Author

Rihcus commented Aug 8, 2019

I get an ad on this video https://www.crunchyroll.com/isekai-cheat-magician/episode-1-lost-ones-from-another-world-787185 using Chrome V76 and default filter lists. The filter crunchyroll.com##+js(setInterval-defuser, onAdVideoStart) doesn't seem to work. Maybe the ads are only specific to certain regions? I'm in the US if that helps.

I don't think so I only seem to get the ads on chrome. One firefox and safari using stock filters I don't get ads. I'm also located in the US.

This issue came up before chrome 76 to however under chrome's flag settings their was an option called enable network settings. With that feature, disabled crunchy roll ads seemed to be blocked. However, on 76 googles removed the flag and subsequently the option to disable it. Ads then came back.

@ghost
Copy link

ghost commented Aug 14, 2019

Why does this issue only happen on chrome? On safari and firefox I get no ads, but on Chrome I get ads. Is there a solution here? I've already tried to add the filter listed in this thread

@ghost
Copy link

ghost commented Aug 14, 2019

BTW - check my issue that was closed for being a duplicate above - it has steps to reproduce this issue 100% of the time.

@uBlock-user uBlock-user added the Chromium specific to Chromium/Chrome label Aug 14, 2019
@gwarser
Copy link
Member

gwarser commented Aug 28, 2019

@rushilmehra I tried your steps and cannot reproduce.

@gwarser
Copy link
Member

gwarser commented Sep 14, 2019

Wondering if json-prune may help here.

Shothing blindly:

 crunchyroll.com##+js(json-prune, setup, description setup ts)

uBO-dev required.

@ghost
Copy link

ghost commented Sep 14, 2019

Lol I've just been using Brave as my main browser. Works flawlessly.

@uBlock-user
Copy link
Contributor

Brave is another Chromium clone, so that's not the case.

@ghost
Copy link

ghost commented Sep 15, 2019

Uh, brave is based off of chromium yes. There was a GOOGLE chrome flag that was removed by GOOGLE, that was at the core of blocking ads on certain sites, one of them being Crunchyroll. If my proof as to ublock origin failing is "not the case", then what is the case? Why does it work on Brave and not Google chrome? Which by the way differs in many ways other than underlying functionality.

@uBlock-user
Copy link
Contributor

uBlock-user commented Sep 15, 2019

There was a GOOGLE chrome flag that was removed by GOOGLE, that was at the core of blocking ads on certain sites, one of them being Chromium.

There isn't a google flag that blocks ads, please avoid using this false statement as an argument, on the contrary that flag was causing network requests to bypass uBO and ads were seen when that flag was enabled, disabling the flag took care of that but since that flag was only experimental in nature it was removed by Google like it does with all things it tests. If it works on Chromium, it will work on all the forks/clones based off it and not the other way around.

Only few users like yourself are facing this issue and as to why that's a mystery because so far nobody from the team has been able to reproduce ads once the filter is used or uBO is enabled.

@ghost
Copy link

ghost commented Sep 15, 2019

I said it was at the CORE of blocking ads - which it was, for many people. I have tested it on every device in my house with chrome 76, and all of them fail even with the filter mentioned above.

@ghost
Copy link

ghost commented Sep 15, 2019

Btw, I don't know if this makes a difference, but no ads show up when I use incognito mode - on every device. However, as soon as you use crunchyroll outside of incognito mode, ads will appear.

@uBlock-user
Copy link
Contributor

uBlock-user commented Sep 15, 2019

I said it was at the CORE of blocking ads

The experimental flag is called “Enable network service,” tells Chrome to launch a separate process for “service workers,” or background tasks for web pages. A few bugs in service workers, combined with the network service experiment, was inadvertently bypassing Chrome extensions. Google identified and reportedly fixed one of the bugs in time for Chrome 73 while the other was fixed just in time for the stable release of Chrome 73.[1]

[1]src -- https://9to5google.com/2019/02/19/chrome-72-extensions-bug/

https://twitter.com/jviide/status/1097294135898357760, https://twitter.com/jviide/status/1096947294920949760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium specific to Chromium/Chrome filterlist a filter list issue invalid not a uBlock issue unable to reproduce cannot reproduce the issue
Projects
None yet
Development

No branches or pull requests

7 participants