-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In moddriver, <var>mdriver is not set to <var>0driver at simulation start #88
Comments
I have looked at this further after observing example sim 502 seemingly running ok - the simulation probably won't crash unless there are blocks right next to the inlet at i=2. If there are, then in
sets thlm to zero inside the block (because initially But even if the blocks are not next to the inlet, I think this will still cause errors. |
@tomgrylls noted that the buildings for driven simulations as 502 cannot be too close to the downwind edge of the domain, see: https://github.com/uDALES/u-dales/blob/master/docs/udales-simulation-setup.md#running-driven-simulations. Would it be sufficient to just extend the docs there and say that buildings also must not be too close to the inlet? Generally, we need to think about where to put this information, currently the |
Maybe, but this is numerical, whereas the reason that blocks can't be too close to the downwind edge is more physical right? As it's to do with the wakes of the last row of blocks. |
yes good point, if there's an issue in the implementation then that needs to be addressed. |
@samoliverowens not sure if I fully understand your comment here. So you think the problem is just the very first time that this is called? i.e. time = 0? My understanding of this is that we are in the Even in the first time step, and when this called by Please correct me if I have misunderstood. But I think that that the correction of |
@tomgrylls essentially I think we want to set thlmdriver = thl0driver initially (before timestepping) - would you agree? |
@samoliverowens Agreed - okay I see, so it is because |
Ok I'll put in a PR with this change - I agree that it making |
When running driven simulations, I noticed that the temperature would go to zero on the first timestep due to the fact that
thlmdriver
is initially set to zero. This occurs because of the conditionrk3step == 1
in the following sequence indrivergen
, which is called byboundary
before time-stepping begins (when the condition is false).I have simply changed the condition to be
rk3step .le. 1
, but maybe this isn't optimal.The text was updated successfully, but these errors were encountered: