Add support for circles and arcs in symbols

[Bouni]

By now circles and arcs are not supported which leads to wierd symbles sometimes, here's nan example for C318884

Easyeda symbol:

KiCAD symbol generated by this tool:

According to the code, circles and arcs are not yet implemented:

easyeda2kicad.py/easyeda2kicad/easyeda/parameters_easyeda.py

Lines 143 to 152 in 6ac7bae

	# ---------------- CIRCLE ----------------
	class EeSymbolCircle(BaseModel):
	... # TODO
	# ---------------- ARC ----------------
	class EeSymbolArc(BaseModel):
	... # TODO

The code even states that arcs are not supported by KiCAD but thats not true for V6.0 / V6.99 (elliptical arcs are not supported, thats true)

easyeda2kicad.py/easyeda2kicad/easyeda/easyeda_importer.py

Lines 64 to 72 in 6ac7bae

	elif designator == "PI":
	# Elliptical arc seems to be not supported in Kicad
	...
	# For ellipse
	elif designator == "E":
	... # Ellipse seems to be not supported in Kicad
	# For arcs
	elif designator == "A":
	... # TODO

[Bouni]

Nice, circles seem to work in the latest dev commit 😍

[uPesy]

Yes but i'm not sure if i should enable filling the background (having the circle with yellow background)
The circle are descrided as ellipse in the easyeda footprint 🤔

[Bouni]

Does the easyeda data show if their symbol has filled circles or not?

[uPesy]

No i don't think so

[Bouni]

In that case I would no fill them in ...

[uPesy]

Yeah you're right, but in easyeda, there is no background filling on symbol, contrary to Kicad :

[Bouni]

For C318884: background fill in circles is gone, looks good to me!

The optocoupler issue is answered in #53

[uPesy]

Symbol arc is now supported in the last version v0.5.0.
Note that easyeda use elleptical arc while Kicad support only circle arc.

[Bouni]

Are you aware of a symbol that use actual elliptical arcs?

I mean they most likely use elliptical arcs as "normal" arcs but never as an elliptical shape, right?

[uPesy]

For the coil, the radius is rx=3.9 and ry=4.0 on Easyeda

I mean they most likely use elliptical arcs as "normal" arcs but never as an elliptical shape, right?
Yes

[Bouni]

What do you plan to do in such cases?
I could imagine having a threshold for the difference in rx and ry of lets say 0.1mm and if that threshold is not exceeded use one of the values as arc radius. That way we end up wit usable symbols that might not fit a 100% but still better than skip the arcs completely.

[uPesy]

For now it takes the maximum value from rx and ry

[Bouni]

Maybe easier as my suggestion. Thinks that'll do the job.