This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix: Fix app hang when promise returns undefined #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
previously requested changes
Oct 12, 2017
| // Ensure messages exist and check for group filtering | ||
| if (result.messages && result.messages.length > 0) { | ||
| allMessages = result.messages; | ||
| if (result) { |
There was a problem hiding this comment.
❓ should this be handled at the messagesService layer?
replacing undefined with []?
❓ could this be labeled with TODO or FIXME as a reminder that it is a short term fix?
apetro
approved these changes
Oct 12, 2017
thevoiceofzeke
dismissed
ChristianMurphy’s stale review
Implemented requested change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pointing star app at new messages feed, the service fails to get messages (a bigger problem than this PR addresses). When it fails, the angular controls hangs because the promise returns
undefined. This PR just makes sure the block doesn't continue if the promise result is undefined.Contributor License Agreement adherence: