fix: remove search total badge and controller support for

Was bugged to always total to zero. Removing the feature "fixes the bug" reduces bulk of code to maintain and is no less clear a user experience.
uPortal-Attic · Mar 20, 2018 · e848612 · e848612
1 parent 98aa1d0
commit e848612
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 18 deletions.
diff --git a/web/src/main/webapp/my-app/search/controllers.js b/web/src/main/webapp/my-app/search/controllers.js
@@ -152,7 +152,6 @@ define([
         $scope.googleSearchEnabled = false;
         $scope.googleResultsEstimatedCount = 0;
         $scope.googleEmptyResults = false;
-        $scope.totalCount = 0;
         $scope.searchResultLimit = 20;
         $scope.showAll = $rootScope.GuestMode || false;
         base.setupSearchTerm();
@@ -166,22 +165,6 @@ define([
         }).catch(function() {
           $log.warn('Could not getPortlets');
         });
-        $scope.$watchGroup([
-            'googleResultsEstimatedCount',
-            'myuwFilteredResults.length',
-            'wiscDirectoryResultCount'],
-          function() {
-            $scope.totalCount = 0;
-            if ($scope.googleResultsEstimatedCount) {
-              $scope.totalCount+= parseInt($scope.googleResultsEstimatedCount);
-            }
-            if ($scope.myuwFilteredResults) {
-              $scope.totalCount+= parseInt($scope.myuwFilteredResults.length);
-            }
-            if ($scope.wiscDirectoryResultCount) {
-              $scope.totalCount+= parseInt($scope.wiscDirectoryResultCount);
-            }
-          });
       };
       init();
 

diff --git a/web/src/main/webapp/my-app/search/partials/search-results.html b/web/src/main/webapp/my-app/search/partials/search-results.html
@@ -25,7 +25,7 @@
       <!-- ALL RESULTS -->
       <md-tab>
         <md-tab-label>
-          All&nbsp;&nbsp;<span class="badge">{{ totalCount }}</span>
+          All</span>
         </md-tab-label>
         <md-tab-body>
           <md-content>