Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix: Separate remove button into own controller #718

Merged
merged 1 commit into from
Oct 4, 2017

Conversation

thevoiceofzeke
Copy link
Contributor

@thevoiceofzeke thevoiceofzeke commented Oct 4, 2017

This is a conflict-free version of #699

In this PR:

  • Broke functionality for widget remove button into its own controller
  • Replaced jQuery stuff with angular filters or plain javascript

Why?

The functionality used to live in LayoutController, and every instance of a <remove-button> in a user's layout was causing LayoutController to initialize (including the getLayout() service call. It's probably better if each instance of the remove button only initializes what it needs to function.

Proof that it still works

remove-button


Contributor License Agreement adherence:

Copy link
Contributor

@davidmsibley davidmsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it.

@thevoiceofzeke thevoiceofzeke merged commit 9d8f13c into uPortal-Attic:master Oct 4, 2017
@davidmsibley davidmsibley added this to the 7.0.3 milestone Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants