Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect UserAgent.Minor #51

Closed
t-vorobyova opened this issue Aug 28, 2018 · 1 comment
Closed

Incorrect UserAgent.Minor #51

t-vorobyova opened this issue Aug 28, 2018 · 1 comment

Comments

@t-vorobyova
Copy link

I have the following user-agent:
Mozilla/5.0 (iPhone; CPU iPhone OS 11_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Coast/5.04.110603 Mobile/15F79 Safari/7534.48.3
BrowserMinorVersion (UserAgent.Minor) is parsed incorrectly, it is parsed as "04" instead of "4"
@dgoldstein0
Copy link
Contributor

... that seems pretty reasonable behavior? in 5.04 I wouldn't say the decimal is 4 but rather 04

do other ua-parser implementations handle this differently? if so I could be convinced this is an issue if the golang implementation is in the minority. Until then I'm assuming this is expected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgoldstein0 @t-vorobyova