Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reg Edge browser parsing #22

Closed
omkumar87 opened this issue Feb 17, 2017 · 3 comments
Closed

Reg Edge browser parsing #22

omkumar87 opened this issue Feb 17, 2017 · 3 comments

Comments

@omkumar87
Copy link

Hi

I have used this ua parser for parsing user agents.
It is returning chrome for the Edge browser.
Can you please add support for the same.

Thanks.

@mormegil-cz
Copy link

This repository does not contain the user-agent parsing data itself which is responsible for the mapping, it contains only the parsing support for Java. The problems in the data should be reported in the ua-core repository. And this bug was already reported and fixed (since 7 Jun).

@jeronimonunes
Copy link

How could I update the ua-core dependency of uap-java, so it would correctly parse the user-agent of Microsoft Edge? Or maybe the fix on the previous comment was to the old Microsoft Edge and the new Edgium now have the same bug!?!? Shouldn't a new release of this library be submitted to maven central?

The ua string that I'm trying to parse is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36 Edg/83.0.478.56

@bpossolo
Copy link
Contributor

Hi @omkumar87 and @jeronimonunes
Edge support was added in release 1.4.4

@jeronimonunes the user agent string you supplied now returns Edge for userAgent.family

Note: to get the latest version you'll want to upgrade to 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants