Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Job fails for some input arguments that are treated as string (str vs int comparison #143

Closed
astrochun opened this issue Apr 2, 2021 · 0 comments · Fixed by #144
Closed
Assignees
Labels
bug Something isn't working scripts Script development
Milestone

Comments

@astrochun
Copy link
Contributor

Describe the bug (REQUIRED)
Parsing of input arguments is treated as string. In some cases, this inputs are integer:
This results in the following error

Traceback (most recent call last):
  File "./scripts/script_run", line 394, in <module>
    d.synchronize()
  File "/home/mozart/codes/ReQUIAM/requiam/delta.py", line 73, in synchronize
    if total_delta > self.sync_max:
TypeError: '>' not supported between instances of 'int' and 'str'

Version information (please complete the following, default in brackets): (REQUIRED)

  • ReQUIAM version: 0.16.1
  • ReQUIAM branch info: master

Reproduction Steps (REQUIRED)
Steps to reproduce the behavior:

  1. script_run --quota --sync_max 1500 --sync

Expected behavior (Optional)
Job should run with a higher sync max.

@astrochun astrochun added bug Something isn't working scripts Script development labels Apr 2, 2021
@astrochun astrochun added this to the v0.17.0 milestone Apr 2, 2021
@astrochun astrochun self-assigned this Apr 2, 2021
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Apr 2, 2021
@astrochun astrochun mentioned this issue Apr 2, 2021
4 tasks
@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Apr 2, 2021
ReDATA Patron Management Software automation moved this from In progress to Done Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scripts Script development
Development

Successfully merging a pull request may close this issue.

1 participant