Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in user_update script when neither --portal or --quota is specified #49

Closed
astrochun opened this issue Aug 4, 2020 · 0 comments · Fixed by #48
Closed

Bug in user_update script when neither --portal or --quota is specified #49

astrochun opened this issue Aug 4, 2020 · 0 comments · Fixed by #48
Assignees
Labels
bug Something isn't working scripts Script development
Milestone

Comments

@astrochun
Copy link
Contributor

astrochun commented Aug 4, 2020

The following error message was encountered when both --portal and --quota were not specified:

Traceback (most recent call last):
  File "scripts/user_update", line 164, in <module>
    if not portal_check or not quota_check:
NameError: name 'portal_check' is not defined

Simple solution is to pre-defined portal_check and quota_check. This avoids the SystemError when either of them do not exists on Grouper

A separate warning should be made to indicate the neither of them are set.

@astrochun astrochun added bug Something isn't working scripts Script development labels Aug 4, 2020
@astrochun astrochun self-assigned this Aug 4, 2020
@astrochun astrochun added this to To do in ReDATA Patron Management Software via automation Aug 4, 2020
@astrochun astrochun moved this from To do to In progress in ReDATA Patron Management Software Aug 4, 2020
@astrochun astrochun mentioned this issue Aug 4, 2020
ReDATA Patron Management Software automation moved this from In progress to Done Aug 4, 2020
@astrochun astrochun added this to the v0.12.0 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scripts Script development
Development

Successfully merging a pull request may close this issue.

1 participant