You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the patch, LunkRat! You might be the first to submit a patch in response to an issue. :-)
Unfortunately, I can't accept the patch as-is, for two reasons:
It appears to do the opposite of what you intended, i.e., it removes the protocol-less URL (which I assume is your fix, and it's a good solution) and reinstates the hard-coded "http://". This is probably just a simple patch-creation issue.
More importantly, in the latest version of GotS, I've included jQuery with the code instead of using a CDN. So there won't be an HTTPS issue.
But I'm not really happy with my solution (no CDN caching benefits), so I'm going to combine your excellent idea with my the local jQuery idea and see if that solves all of it...
Thanks again @LunkRat -- the next release of GotS will include jQuery (and the Google Fonts) with a protocol-less URL from the Google CDN and fall back to local.
I tried to run GOTS over https: and found that the jQuery library was being blocked as "mixed content" because GOTS was loading it via http:
No jQuery = unhappy GOTS (dialog boxes are broken in the editor, etc.)
Fixed and added a patch: https://gist.github.com/LunkRat/6612102
With the above patch GOTS works over https:
The text was updated successfully, but these errors were encountered: