Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol is hardcoded for jQuery CDN (allow https) #32

Closed
LunkRat opened this issue Sep 18, 2013 · 4 comments
Closed

Protocol is hardcoded for jQuery CDN (allow https) #32

LunkRat opened this issue Sep 18, 2013 · 4 comments
Assignees
Labels
Milestone

Comments

@LunkRat
Copy link

LunkRat commented Sep 18, 2013

I tried to run GOTS over https: and found that the jQuery library was being blocked as "mixed content" because GOTS was loading it via http:

No jQuery = unhappy GOTS (dialog boxes are broken in the editor, etc.)

Fixed and added a patch: https://gist.github.com/LunkRat/6612102

With the above patch GOTS works over https:

@michaelhagedon
Copy link
Member

Thanks for the patch, LunkRat! You might be the first to submit a patch in response to an issue. :-)

Unfortunately, I can't accept the patch as-is, for two reasons:

  • It appears to do the opposite of what you intended, i.e., it removes the protocol-less URL (which I assume is your fix, and it's a good solution) and reinstates the hard-coded "http://". This is probably just a simple patch-creation issue.
  • More importantly, in the latest version of GotS, I've included jQuery with the code instead of using a CDN. So there won't be an HTTPS issue.

But I'm not really happy with my solution (no CDN caching benefits), so I'm going to combine your excellent idea with my the local jQuery idea and see if that solves all of it...

@ghost ghost assigned michaelhagedon Sep 18, 2013
@michaelhagedon
Copy link
Member

Thanks again @LunkRat -- the next release of GotS will include jQuery (and the Google Fonts) with a protocol-less URL from the Google CDN and fall back to local.

@LunkRat
Copy link
Author

LunkRat commented Sep 18, 2013

Thanks for the commit! Now jQuery loading will be much heartier.

Fixed my patch: https://gist.github.com/LunkRat/6612102 (I was on the wrong branch when I created the patch earlier, oops)

Cheers

@michaelhagedon
Copy link
Member

Thanks! That's what I figured you meant. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants