Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis #33

Closed
edvilme opened this issue Feb 2, 2021 · 9 comments
Closed

Emojis #33

edvilme opened this issue Feb 2, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@edvilme
Copy link

edvilme commented Feb 2, 2021

Hello! I enjoy using this service very much! Congrats and thanks to the community :D

I have noticed that emoji are parsed into the text and was wondering if there was a way to escape \uXXXX (unicode for emoji), treating them as proper nouns as to preserve them?
I would like to do any type of contribution but wanted to make sure if it is currently possible before messing around with the code.

Thanks in advance

@pierotofy pierotofy added enhancement New feature or request help wanted labels Feb 2, 2021
@pierotofy
Copy link
Member

Hey @edvilme ✋ that would be a cool addition. I haven't experimented with emojis much, but I would assume it's probably possible to make it work (like you say, by escaping them into nouns).

This might be better suited as a PR for https://github.com/argosopentech/argos-translate though, since it's the translation engine.

@PJ-Finlay
Copy link
Contributor

Done, good idea!

argosopentech/argos-translate@6a0f389

@pierotofy
Copy link
Member

w00t, that's awesome!

@edvilme
Copy link
Author

edvilme commented Feb 8, 2021

Wait what? OMG awesomeee!

@pierotofy
Copy link
Member

image

This can be closed!

@graysuit
Copy link

Hi guys,
It looks unstable.

It fails.
Sometime it remove some emoji from text.
Sometime it replace emoji with some other text.

Its telegram emoji that I used in pic. ✅
Capture

@PJ-Finlay
Copy link
Contributor

@graysuit
Copy link

It mean it fixed in code but NOT fixed yet on api ?

@PJ-Finlay
Copy link
Contributor

It's fixed in the code that processes the data for training models but the Spanish model hasn't been retrained since this fix was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants