Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function1: CleverClean #7

Closed
aimee0317 opened this issue Jan 15, 2022 · 3 comments · Fixed by #2
Closed

Function1: CleverClean #7

aimee0317 opened this issue Jan 15, 2022 · 3 comments · Fixed by #2
Assignees
@Arushi282
Projects
Python Package
Milestone
Milestone2

Comments

@aimee0317
Copy link
Collaborator

No description provided.

@aimee0317 aimee0317 added this to the Milestone1 milestone Jan 15, 2022
@aimee0317 aimee0317 added this to In progress in Python Package Jan 15, 2022
@aimee0317 aimee0317 changed the title Function1: CleverClean Function1: CleverClean - Doc String Jan 15, 2022
@aimee0317 aimee0317 linked a pull request Jan 15, 2022 that will close this issue
Adding CleverClean.py #2
Merged
@aimee0317 aimee0317 moved this from In progress to Done in Python Package Jan 15, 2022
@aimee0317 aimee0317 moved this from Done to To do in Python Package Jan 18, 2022
@aimee0317 aimee0317 reopened this Jan 18, 2022
@aimee0317 aimee0317 changed the title Function1: CleverClean - Doc String Function1: CleverClean Jan 18, 2022
@aimee0317 aimee0317 modified the milestones: Milestone1, Milestone2 Jan 18, 2022
@Arushi282
Copy link
Collaborator

Arushi282 commented Jan 19, 2022 •
edited

Hi @aimee0317, @adrianne-l, and @Vikiano

Working on writing the cleverclean function, aside from converting text to lower case and removing punctuation, should I also preprocess the text to remove all digits?

@aimee0317
Copy link
Collaborator Author

I think we should remove the digits because they are usually not that useful in wordcloud. What do you think?

@Arushi282
Copy link
Collaborator

I think we should remove the digits because they are usually not that useful in wordcloud. What do you think?

Yes I agree as well, in most cases it would be quite arbitrary to have numbers show up in our final world cloud, okay will make changes to the documentation accordingly, thanks!

@aimee0317 aimee0317 moved this from To do to Done in Python Package Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arushi282 Arushi282

Labels
None yet
Projects
Python Package
Done
Milestone
Milestone2
Development

Successfully merging a pull request may close this issue.

Adding CleverClean.py UBC-MDS/clevercloud
2 participants
@aimee0317 @Arushi282