Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs and home button don't use $base_path #7

Closed
reinette opened this issue Feb 11, 2013 · 1 comment
Closed

Breadcrumbs and home button don't use $base_path #7

reinette opened this issue Feb 11, 2013 · 1 comment

Comments

@reinette
Copy link

The template seems to assume that the site is deployed at the root of a domain. Not always true :)

The $breadcrumb in megatron_breadcrumb() simply has an a href="/" for the home breadcrumb, better would be to use $base_path, which defaults to "/" if its not set.

The megatron_ubc_clf_header() function makes the same assumption.

@occupant
Copy link
Member

You're absolutely right. I've updated and committed the changes.

Cheers,
James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants