-
Notifications
You must be signed in to change notification settings - Fork 25
/
ubcpi_edit_spec.js
490 lines (418 loc) · 19.7 KB
/
ubcpi_edit_spec.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
'use strict';
describe('UBCPI_Edit module', function () {
var mockConfig, mockNotify;
beforeEach(function () {
mockNotify = jasmine.createSpy('notify');
module(function ($provide) {
$provide.value('notify', mockNotify);
});
});
beforeEach(module(function($provide) {
mockConfig = {
data: {},
urls: {}
};
$provide.provider('$rootElement', function() {
this.$get = function() {
var elem = angular.element('<div ng-app></div>');
elem[0].config = mockConfig;
return elem;
};
});
}, 'ubcpi_edit'));
describe('validateForm directive', function () {
var $compile, scope, studioBackendService, $q;
// Store references to $rootScope and $compile
// so they are available to all tests in this describe block
beforeEach(inject(function (_$compile_, _$rootScope_, _studioBackendService_, _$q_) {
// The injector unwraps the underscores (_) from around the parameter names when matching
$compile = _$compile_;
scope = _$rootScope_;
studioBackendService = _studioBackendService_;
$q = _$q_;
scope.form = {
display_name: 'PI'
};
var element = angular.element(
'<form name="piForm" validate-form ng-model="form">' +
'<input name="display_name" ng-model="form.display_name" type="text" required />' +
'</form>'
);
$compile(element)(scope);
}));
it('should call backend service to validate form', function () {
var defer = $q.defer();
spyOn(studioBackendService, 'validateForm').and.callFake(function () {
return defer.promise;
});
defer.resolve();
scope.$apply();
expect(studioBackendService.validateForm).toHaveBeenCalledWith(scope.form);
});
it('should invalidate form when backend validate returns error', function () {
var defer = $q.defer();
spyOn(studioBackendService, 'validateForm').and.callFake(function () {
return defer.promise;
});
defer.reject({error: 'invalid name'});
scope.$apply();
expect(scope.piForm.$errors).toEqual('invalid name');
})
});
describe('studioBackendService', function () {
var studioBackendService, $httpBackend, formData;
beforeEach(inject(function (_studioBackendService_, _$httpBackend_) {
studioBackendService = _studioBackendService_;
$httpBackend = _$httpBackend_;
formData = {
display_name: 'PI'
};
}));
afterEach(function () {
$httpBackend.verifyNoOutstandingExpectation();
$httpBackend.verifyNoOutstandingRequest();
});
describe('validate_form', function () {
beforeEach(function () {
mockConfig.urls.validate_form = '/handler/validate_form';
});
it('should call backend validate form', function () {
var data = undefined;
$httpBackend.expectPOST('/handler/validate_form', formData).respond(200);
studioBackendService.validateForm(formData).then(function (d) {
data = d;
});
$httpBackend.flush();
expect(data).toBe(true);
});
it('should reject promise with error returned from backend when backend error', function () {
var error = undefined;
$httpBackend.expectPOST('/handler/validate_form', formData).respond(500, {error: 'error'});
studioBackendService.validateForm(formData).catch(function (e) {
error = e;
});
$httpBackend.flush();
expect(error).toEqual({error: 'error'});
});
});
describe('studio_submit', function () {
beforeEach(function () {
mockConfig.urls.studio_submit = '/handler/studio_submit';
});
it('should submit form', function () {
var exp = 'whatever';
var data = undefined;
$httpBackend.expectPOST('/handler/studio_submit', formData).respond(200, exp);
studioBackendService.submit(formData).then(function (d) {
data = d;
});
$httpBackend.flush();
expect(data).toEqual(exp);
});
it('should reject promise with error returned from backend when backend error', function () {
var error = undefined;
$httpBackend.expectPOST('/handler/studio_submit', formData).respond(500, {errors: 'error'});
studioBackendService.submit(formData).catch(function (e) {
error = e;
});
$httpBackend.flush();
expect(error).toEqual({errors: 'error'});
})
})
});
describe('EditSettingsController', function () {
var $rootScope, createController, controller;
beforeEach(inject(function ($controller, _$rootScope_) {
mockConfig.data = {
"correct_rationale": {"text": "correct rationale"},
"image_position_locations": {"below": "Appears below", "above": "Appears above"},
"rationale_size": {"max": 32000, "min": 1},
"display_name": "Peer Instruction",
"algo": {"num_responses": "#", "name": "simple"},
"algos": {
"simple": "System will select one of each option to present to the students.",
"random": "Completely random selection from the response pool."
},
"correct_answer": 1,
"seeds": [
{answer:2, rationale:'rationale3'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'},
{answer:2, rationale:'rationale3'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'}
],
"question_text": {
"text": "What is the answer to life, the universe and everything?",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
},
"options": [
{
"text": "21",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}, {
"text": "42",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}, {
"text": "63",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}
]
};
$rootScope = _$rootScope_;
createController = function (params) {
return $controller(
'EditSettingsController', {
$scope: $rootScope,
$stateParams: params || {}
});
}
}));
beforeEach(function() {
controller = createController();
});
it('should have correct initial states', function () {
expect(controller.algos).toBe(mockConfig.data.algos);
expect(controller.data.display_name).toBe(mockConfig.data.display_name);
expect(controller.data.question_text).toBe(mockConfig.data.question_text);
expect(controller.data.rationale_size).toBe(mockConfig.data.rationale_size);
expect(controller.image_position_locations).toBe(mockConfig.data.image_position_locations);
expect(controller.data.options).toBe(mockConfig.data.options);
expect(controller.data.correct_answer).toBe(mockConfig.data.correct_answer);
expect(controller.data.correct_rationale).toBe(mockConfig.data.correct_rationale);
expect(controller.data.algo).toBe(mockConfig.data.algo);
expect(controller.data.seeds).toBe(mockConfig.data.seeds);
});
it('should add option to the data when add_option is called', function() {
var num_options = mockConfig.data.options.length;
expect(controller.data.options.length).toBe(num_options);
controller.add_option();
expect(controller.data.options.length).toBe(num_options + 1);
expect(controller.data.options[controller.data.options.length - 1]).toEqual(
{'text': '', 'image_url': '', 'image_position': 'below', 'image_show_fields': 0, 'image_alt': ''}
);
});
it('should delete option to the data when delete_option is called', function() {
var num_options = mockConfig.data.options.length;
expect(controller.data.options.length).toBe(num_options);
controller.delete_option(1);
expect(controller.data.options.length).toBe(num_options - 1);
expect(controller.data.options).toEqual(
[{
"text": "21",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}, {
"text": "63",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}]
);
});
it('should add "n/a" option to a return options array when makeOptions is called', function() {
var options = controller.makeOptions();
expect(controller.data.options.length+1).toBe(options.length);
expect(options[options.length-1]).toEqual("n/a");
});
it('should return false when noCorrect is called, given a correct answer of index 1', function() {
expect(controller.noCorrect()).toBe(true);
});
it('should fail silently when invalid index is give to delete_option', function() {
controller.delete_option(5);
expect(controller.data.options.length).toBe(3);
});
it('should add seed when addSeed is called', function() {
var num_seeds = mockConfig.data.seeds.length;
expect(controller.data.seeds.length).toBe(num_seeds);
controller.addSeed();
expect(controller.data.seeds.length).toBe(num_seeds + 1);
expect(controller.data.seeds[controller.data.seeds.length - 1]).toEqual({});
});
it('should delete seed to the data when deleteSeed is called', function() {
var num_seeds = mockConfig.data.seeds.length;
expect(controller.data.seeds.length).toBe(num_seeds);
controller.deleteSeed(1);
expect(controller.data.seeds.length).toBe(num_seeds - 1);
expect(controller.data.seeds).toEqual([
{answer:2, rationale:'rationale3'},
{answer:0, rationale:'rationale1'},
{answer:2, rationale:'rationale3'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'}
]);
});
it('should delete seeds containing an option when delete_option is called', function(){
var num_seeds = mockConfig.data.seeds.length;
controller.delete_option(2);
expect(controller.data.seeds.length).toBe(num_seeds - 2);
expect(controller.data.seeds).toEqual([
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'}
])
});
it('should fail silently when invalid index is give to deleteSeed', function() {
controller.deleteSeed(7);
expect(controller.data.seeds.length).toBe(6);
});
it('should flip the show image fields when image_show_fields is called', function() {
expect(controller.data.question_text.image_show_fields).toBe(0);
controller.image_show_fields(false);
expect(controller.data.question_text.image_show_fields).toBe(true);
controller.image_show_fields(false);
expect(controller.data.question_text.image_show_fields).toBe(false);
expect(controller.data.options[1].image_show_fields).toBe(0);
controller.image_show_fields(1);
expect(controller.data.options[1].image_show_fields).toBe(true);
controller.image_show_fields(1);
expect(controller.data.options[1].image_show_fields).toBe(false);
});
describe('submit', function () {
var backendDeferred, studioBackendService;
beforeEach(inject(function ($q, _studioBackendService_) {
backendDeferred = $q.defer();
studioBackendService = _studioBackendService_;
}));
it('should set the submitting status and show the notification', function () {
spyOn(studioBackendService, 'submit').and.callFake(function () {
return backendDeferred.promise;
});
controller.submit();
expect(mockNotify).toHaveBeenCalledWith('save', {state: 'start', message: "Saving"});
backendDeferred.resolve();
$rootScope.$apply();
expect(mockNotify.calls.count()).toBe(2);
expect(mockNotify.calls.argsFor(1)).toEqual(['save', {state: 'end'}]);
});
it('should call backendService with correct parameters', function () {
spyOn(studioBackendService, 'submit').and.callFake(function () {
return backendDeferred.promise;
});
controller.submit();
backendDeferred.resolve();
$rootScope.$apply();
expect(studioBackendService.submit).toHaveBeenCalledWith(controller.data);
});
it('should clear the submitting status when failed', function () {
spyOn(studioBackendService, 'submit').and.callFake(function () {
return backendDeferred.promise;
});
controller.submit();
backendDeferred.reject('backend error');
$rootScope.$apply();
expect(mockNotify.calls.count()).toBe(3);
});
});
});
describe('EditSettingsControllerWithoutOptionalParam', function () {
var $rootScope, createController, controller, expectedCorrectRationale;
beforeEach(inject(function ($controller, _$rootScope_) {
mockConfig.data = {
"image_position_locations": {"below": "Appears below", "above": "Appears above"},
"rationale_size": {"max": 32000, "min": 1},
"display_name": "Peer Instruction",
"algo": {"num_responses": "#", "name": "simple"},
"algos": {
"simple": "System will select one of each option to present to the students.",
"random": "Completely random selection from the response pool."
},
"correct_answer": 1,
"seeds": [
{answer:2, rationale:'rationale3'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'},
{answer:2, rationale:'rationale3'},
{answer:1, rationale:'rationale2'},
{answer:0, rationale:'rationale1'}
],
"question_text": {
"text": "What is the answer to life, the universe and everything?",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
},
"options": [
{
"text": "21",
"image_show_fields": 0,
"image_url": "",
"image_position": "below",
"image_alt": ""
}
]
};
$rootScope = _$rootScope_;
createController = function (params) {
return $controller(
'EditSettingsController', {
$scope: $rootScope,
$stateParams: params || {}
});
};
controller = createController();
expectedCorrectRationale = {"text": ""};
}));
it('should have correct initial states', function () {
expect(controller.algos).toBe(mockConfig.data.algos);
expect(controller.data.display_name).toBe(mockConfig.data.display_name);
expect(controller.data.question_text).toBe(mockConfig.data.question_text);
expect(controller.data.rationale_size).toBe(mockConfig.data.rationale_size);
expect(controller.image_position_locations).toBe(mockConfig.data.image_position_locations);
expect(controller.data.options).toBe(mockConfig.data.options);
expect(controller.data.correct_answer).toBe(mockConfig.data.correct_answer);
expect(controller.data.correct_rationale).toEqual(expectedCorrectRationale);
expect(controller.data.algo).toBe(mockConfig.data.algo);
expect(controller.data.seeds).toBe(mockConfig.data.seeds);
});
});
});
describe('PIEdit function', function () {
var mockRuntime, mockElement, mockData, mockModule;
beforeEach(function () {
mockRuntime = jasmine.createSpyObj('runtime', ['notify', 'handlerUrl']);
mockRuntime.notify = undefined;
mockRuntime.handlerUrl.and.callFake(function (element, handler) {
return handler;
});
mockElement = [jasmine.createSpy('element')];
mockData = jasmine.createSpy('data');
mockModule = jasmine.createSpyObj('module', ['value', 'constant']);
mockModule.value.and.returnValue(mockModule);
mockModule.constant.and.returnValue(mockModule);
spyOn(angular, 'module').and.returnValue(mockModule);
spyOn(angular, 'bootstrap');
PIEdit(mockRuntime, mockElement, mockData);
});
it('should setup angular module dependencies', function () {
expect(angular.module.calls.count()).toBe(1);
expect(angular.module.calls.argsFor(0)).toEqual(['ubcpi_edit']);
expect(mockModule.value.calls.count()).toBe(1);
expect(mockModule.value.calls.argsFor(0)).toContain('notify');
});
it('should bootstrap angular app', function () {
expect(angular.bootstrap).toHaveBeenCalledWith($(mockElement), ['ubcpi_edit'], {strictDi: true})
});
it('should generate URLs using runtime', function () {
expect(mockRuntime.handlerUrl.calls.count()).toBe(2);
expect(mockRuntime.handlerUrl.calls.allArgs()).toEqual(
[[mockElement, 'studio_submit'], [mockElement, 'validate_form']]);
});
});