Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: customize report on timeout #329

Open
wilbowma opened this issue Mar 13, 2020 · 2 comments
Open

Feature request: customize report on timeout #329

wilbowma opened this issue Mar 13, 2020 · 2 comments

Comments

@wilbowma
Copy link
Contributor

Currently, the default report doesn't give the student access to anything when their container times out. The tests for my course still output a lot of useful information before timing out, and I'd like to be able to give that to students.

@andrewstec
Copy link
Contributor

andrewstec commented Apr 30, 2020

@wilbowma

There may be room for this feature, but it would also need to be refined a bit further with your expectations. How do you envision this feature? Do students get access to just the leftover files, or do they get custom reports built with the data once a timeout threshold is triggered? The former option should already be possible. Were you having any issues with students accessing artifacts from prior grading runs?

I have a potential workaround for you. You could ensure that your grading logic times-out internally if a grading-run is taking too long. For example, if a test takes longer than 2000ms, then abort. If a test-suite takes longer than 1 minute to run, then create a result record with a custom timeout message to supplement the container artifacts. This timeout scenario would not be the container timing out, but it would be the internal grading logic timing out. This may not work with infinite loops, however.

Any additional thoughts would be welcome.

@wilbowma
Copy link
Contributor Author

wilbowma commented May 5, 2020

I was imagining a custom built report for timeout, but I could live with just giving them the the same report and the log file I'm normally generating from their test suite.

Your proposed work-around makes sense. I think the Racket test harness supports sandboxing tests and timing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants