Upgrade to Django 3.2 LTS

[aebruno]

We're currently on Django 2.2 which ends extended support in April 2022. We should upgrade to the latest 3.2 LTS release.

[mdzik]

Hi,

I'm responsible for Coldfront instance at ICM. I have django version update on schedule soon so maybe you will be interested in PR? ;)

We use Kubernetes/Helm for CI/CD and REST to control SLURM so maybe could share some of our other work. At very beginning we had to add Django translation module to CF so it made a braking change but most is still compatible.

Coldfront saved us tons of work - great job!

Michał

[aebruno]

@mdzik Absolutely! All sounds great. Glad to hear ColdFront is working for you. We would be very interested in any PRs so feel free to send some our way. Upgrading Django, REST Slurm and a translation module all sound awesome and areas we could certainly use some help. Thanks!

[mdzik]

So all is well, now over month in tests + 2 weeks in production. We decided to push for Django 4 and all is well
Main issues, apart from PR are related to SSL in python 3.10 - some ciphers are now obsolete and for us LDAP connection stopped working out-of-the-box. And Django SU seems not updated and we turned it off.

Regarding SSL:

Wherever you use python requests etc. you might get (DOI api only?) https://stackoverflow.com/questions/38015537/python-requests-exceptions-sslerror-dh-key-too-small

For LDAPS, if you use old ldap server config you could get:

ldap3.core.exceptions.LDAPSocketOpenError: ("('socket ssl wrapping error: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997)',)",)

see: python/cpython@9ad46f9

Those are local-environment dependent issues so not really testable.

For Django 4 I would need to upgrade url.py ( url() go depracieted) - How far you would like to go? 3 or 4 ;)

[aebruno]

So all is well, now over month in tests + 2 weeks in production. We decided to push for Django 4 and all is well Main issues, apart from PR are related to SSL in python 3.10 - some ciphers are now obsolete and for us LDAP connection stopped working out-of-the-box.

Excellent. Thanks so much for testing.

And Django SU seems not updated and we turned it off.

Curious if you tested v0.9.0? The Changelog here looks like there may be some support for Django 3?

Regarding SSL:

Wherever you use python requests etc. you might get (DOI api only?) https://stackoverflow.com/questions/38015537/python-requests-exceptions-sslerror-dh-key-too-small

For LDAPS, if you use old ldap server config you could get:

ldap3.core.exceptions.LDAPSocketOpenError: ("('socket ssl wrapping error: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:997)',)",)

see: python/cpython@9ad46f9

Those are local-environment dependent issues so not really testable.

Great, thanks for the info. Agreed these are local-env issues.

For Django 4 I would need to upgrade url.py ( url() go depracieted) - How far you would like to go? 3 or 4 ;)

We were actually just talking about this and think we'd like to go all the way to Django 4. If you have something going feel free to submit/update the PR and we'll start testing on our end as well.

Thanks again. All great stuff.

[aebruno]

For Django 4 I would need to upgrade url.py ( url() go depracieted) - How far you would like to go? 3 or 4 ;)

Scratch that, just realized Django 4 is not LTS yet. I'm thinking we upgrade to 3.2 LTS first. Then we'll test the jump to 4.