Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

Remove 'dc' and 'dcvalue'. Allow to load from multiple directories instead. #14

Open
lxe opened this issue Jan 15, 2015 · 5 comments
Open

Comments

@lxe
Copy link
Contributor

lxe commented Jan 15, 2015

I don't think the 'dc' config should be a first-class citizen in this module, or a strict requirement.

Instead, we should be able to provide multiple paths, if you need to load up some host-specific config:

var config = fetchConfig(__dirname, '/etc/datacenter', '/etc/my-app', /* ... */, { }); 
// Probably not the final interface... just something to think about.
@Raynos
Copy link
Contributor

Raynos commented Jan 16, 2015

@lxe

data center specific configuration was a first class requirement of a production quality config loader and will stay so.

@lxe
Copy link
Contributor Author

lxe commented Jan 20, 2015

Data center requirement is not something most people, or even "production" deployments will ever need. This requirement is tightly coupled with pre-existing assumptions about your environment, making zero-config very non-generic.

@Raynos
Copy link
Contributor

Raynos commented Jan 20, 2015

@lxe disagree. If you do not future proof your app you will fail.

An example of "datacenter" is staging vs prod, west vs east.

@lxe
Copy link
Contributor Author

lxe commented Jan 20, 2015

But it's an application/project specific feature, not a zero-config requirement. Zero-config should just load config, instead of managing/enforcing devops requirements.

An example of "datacenter" is staging vs prod, west vs east.

That's similar to what I'm suggesting... we can make environment-based loading generic and still satisfy datacenter requirements of projects that choose to adhere to it.

@fakewaffle
Copy link

I don't think it should be a requirement either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants