feat: blog #1069
Merged
feat: blog #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh3y
force-pushed
the
feat/blog
branch
2 times, most recently
from
fa44178
to
dea4767
Compare
jh3y
force-pushed
the
feat/blog
branch
3 times, most recently
from
01bf044
to
0452199
Compare
|
Looks nice! Just some style nitpicks. I would a add header here ("Blog" ?), so the main content is aligned with the sidebar. And the secondary/primary button might look better.
Same here or you could add some space to the top. The article header section is using Times? The subheading/author color doesn't have enough contrast.
|
|
Made some changes @tajo 👍 Fixed the build by moving some files around 🙌 |
jh3y
force-pushed
the
feat/blog
branch
3 times, most recently
from
8fdceed
to
b8979cc
Compare
gergelyke
reviewed
Mar 28, 2019
gergelyke
approved these changes
Mar 28, 2019
jh3y
force-pushed
the
feat/blog
branch
2 times, most recently
from
563f5cc
to
5ee2920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope