TypeScript Examples #1599
Merged
TypeScript Examples #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajo
requested review from
chasestarr,
gergelyke,
nadiia and
sandgraham
as code owners
chasestarr
reviewed
Jul 23, 2019
| const globby = require('globby'); | ||
| const path = require('path'); | ||
|
|
||
| (async () => { |
Not expected. What example is failing? |
|
this link - https://codesandbox.io/s/0swb2?module=/example.tsx (first button example) it took about 15 seconds to display the error |
Oh right, added missing |
chasestarr
approved these changes
Jul 23, 2019
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
* feat(examples): add TSX version, WIP
* feat(ts-examples): more fixes
* feat(ts-example): fix the rest of examples
* feat(ts-examples): add it to the lang selection WIP
* feat(ts-examples): deploy TS version to cra-ts instance
* feat(ts-example): comment
* feat(ts-examples): fix flow examples, something got borked
* feat(ts-example): add example validation
* feat(ts-examples): ts for pin code component
* fix(examples): remove all <{}> from JS source
* fix(examples): <any, any> doesn't pass through the flow removal
* fix(examples): fix table react-vis codesandbox examples
* feat(ts-examples): add mising styletron types for codesandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All flow (.js) examples now have .tsx counterparts. Visible to users and also integrated with CodeSandbox.