fix(phone-input): removes block component #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasestarr
requested review from
gergelyke,
nadiia,
sandgraham and
tajo
as code owners
nadiia
reviewed
Oct 1, 2019
nadiia
approved these changes
Oct 2, 2019
sandgraham
approved these changes
Oct 2, 2019
baseui-probot-app-workflow
bot
deleted the
removes-block-from-phone-input
branch
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
* feat(phone-input): removes block component * fix(phone-input): extract inline style to component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suppose an application only imports
PhoneInput. That application would be roughly 3kb larger (gzipped) because this component importsBlock. Applications should be able to make the choice to opt-in to block's features in-exchange for the bundle size increaseScope