docs(yard): add file-uploader #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergelyke
requested review from
chasestarr,
nadiia,
sandgraham and
tajo
as code owners
tajo
reviewed
Oct 3, 2019
| import {PropTypes} from '../const'; | ||
| import {TConfig} from '../types'; | ||
|
|
||
| const changleHandlers = [ |
tajo
reviewed
Oct 3, 2019
| description: 'Error message to be displayed.', | ||
| stateful: true, | ||
| }, | ||
| ...changleHandlers.reduce((acc, current) => { |
There was a problem hiding this comment.
I wonder if we should come up with some more robust mechanism to share parts of the documentation. Maybe having config/common.ts with all these handlers and then just picking them across other config files. We already do a lot of sharing for input components. Wdyt?
There was a problem hiding this comment.
that makes sense - I'll do that as part of this PR
gergelyke
force-pushed
the
docs/yard-file-uploader
branch
from
dde7ae1
to
481a4be
Compare
tajo
approved these changes
Oct 3, 2019
VladimirMilenko
pushed a commit
to VladimirMilenko/baseui
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.