Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a component template #295

Merged
merged 1 commit into from Sep 21, 2018
Merged

chore: add a component template #295

merged 1 commit into from Sep 21, 2018

Conversation

nadiia
Copy link
Contributor

@nadiia nadiia commented Sep 21, 2018

No description provided.

@schnerd
Copy link
Contributor

schnerd commented Sep 21, 2018

This is awesome!

As a follow up I wonder if we could also add a yarn run scaffold:component Pagination that automatically copies the template directory and replaces all instances of the string Component with the specified component name. Ideally such a script could even be interactive kind of like the uber-web scaffold, where it asks you questions–one of those questions being whether your component is stateful or not, which would affect the files that are copied. I could also be totally over-thinking this 😛. Either way this PR is a big step forward as-is.

@abmai
Copy link
Contributor

abmai commented Sep 21, 2018

NICE 🚀🚀🚀🚀!!

@nadiia
Copy link
Contributor Author

nadiia commented Sep 21, 2018

This is awesome!

As a follow up I wonder if we could also add a yarn run scaffold:component Pagination that automatically copies the template directory and replaces all instances of the string Component with the specified component name. Ideally such a script could even be interactive kind of like the uber-web scaffold, where it asks you questions–one of those questions being whether your component is stateful or not, which would affect the files that are copied. I could also be totally over-thinking this 😛. Either way this PR is a big step forward as-is.

Yes, that would be ideal.

@nadiia nadiia merged commit 4eb29c2 into master Sep 21, 2018
@gergelyke gergelyke deleted the template-component branch November 28, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants