Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API clean up before 1.0 #147

Merged
merged 1 commit into from
Apr 8, 2019
Merged

API clean up before 1.0 #147

merged 1 commit into from
Apr 8, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 7, 2019

  • parseFile, parseFileSync => parse, parseSync

  • loadFile => load

  • loadFileSync => removed (rarely used, can use parseSync directly).

  • encodeFile, encodeFileSync => encode, encodeSync

  • saveFile => save

@coveralls
Copy link

coveralls commented Apr 7, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 27.313% when pulling 334878f on ib/encode into a16ba9c on master.

@ibgreen ibgreen merged commit 0f2c7ac into master Apr 8, 2019
@ibgreen
Copy link
Collaborator Author

ibgreen commented Apr 8, 2019

The small coverage drop will be addressed in upcoming @loaders.gl/images PR.

@ibgreen ibgreen deleted the ib/encode branch April 8, 2019 16:42
belom88 pushed a commit that referenced this pull request Dec 8, 2020
@dryabinin94
Added warnings + statistics to 'ADD' type of refinement. (#147)
d5397e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @coveralls