Bump deck.gl and fix 3d-tile layer #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Aug 8, 2019
| @@ -135,14 +172,14 @@ export default class Tile3DLayer extends CompositeLayer { | |||
| return changeFlags.somethingChanged; | |||
| } | |||
|
|
|||
| updateState({props, oldProps}) { | |||
| async updateState({props, oldProps}) { | |||
There was a problem hiding this comment.
I think this is OK, but I am pretty sure that deck.gl does not expect its life cycle methods to be async...
Basically, another iteration of this layer could be calling updateState before this function returns.
Worth adding a short comment stating that we are "taking some liberties" here?
| @@ -74,13 +71,56 @@ function commonSpacePlanesToWGS84(viewport) { | |||
| } | |||
| } | |||
|
|
|||
| function getFrameState(viewport, animationProps) { | |||
There was a problem hiding this comment.
+1
Idea: This looks pretty generic. As a second step, we could perhaps move this calculation to Tileset3D. In that case we would want to extact the params from the context first before calling it, as we don't want Tileset3D to know about viewport and animationProps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.