3d-tiles: Optimize quantized positions: normalized shorts and modelMatrix adjustments #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model matrix adjustments
| return decodedArray; | ||
| scratchPosition | ||
| .set(positions[i * 3], positions[i * 3 + 1], positions[i * 3 + 2]) | ||
| // TODO - Remove this when deck.gl allows `normalized` flag to be set on `positions` |
There was a problem hiding this comment.
What is not working right now? You should be able to pass any attribute-like object as an external buffer.
There was a problem hiding this comment.
Stray comment. Will remove. This just started working with the recent alpha, which is why I opened the PR.
xintongxia
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feeding in normalized shorts as position attribute now works in latest 7.3 alpha \o/