Fix full uri #409
Merged
Fix full uri #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Sep 17, 2019
There was a problem hiding this comment.
I could have sworn that @loshjawrence already fixed this. I wonder if it is the same place?
Can someone look up the previous PR?
@xintongxia can you provide some more information about why this was needed?
|
Sorry just saw this. The previous PR didn't have this change. I think without this change you could have multiple nodes in the tree who have a key of |
ibgreen
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseUriis missing, so the tiles'fullUriended up something likeundefined/0/0.b3dm.