core: add context to parse methods
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
force-pushed
the
ib/parse-context
branch
from
6060614
to
e1eb8f8
Compare
xintongxia
reviewed
Sep 19, 2019
| assert(fetch); | ||
| async function fetchAndParseLinkedImage(gltf, image, i, options, context) { | ||
| // const fetch = options.fetch || window.fetch; | ||
| // assert(fetch); |
There was a problem hiding this comment.
This should be done with context. Not used right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextobject to loaders in place of theurlparam.url, thecontextobject containsparseandfetchso that "recursive" loaders no longer need to depend on@loaders.gl/core.Slightly big change to introduce into 1.3, but this will really clean up the plumbing for the 3d-tiles loaders.