3d-tiles & gltf: atomic parser, load all linked assets within one promise #417

ibgreen · 2019-09-19T22:33:14Z

No description provided.

coveralls · 2019-09-19T23:28:32Z

Coverage decreased (-2.8%) to 56.08% when pulling 3976eac on ib/gltf-parse into 3a479d3 on master.

modules/3d-tiles/src/parsers/helpers/parse-3d-tile-gltf-view.js

ibgreen requested a review from xintongxia September 20, 2019 01:30

ibgreen marked this pull request as ready for review September 20, 2019 01:30

ibgreen requested a review from loshjawrence September 20, 2019 01:56

xintongxia approved these changes Sep 20, 2019

View reviewed changes

modules/3d-tiles/src/parsers/helpers/parse-3d-tile-gltf-view.js Show resolved Hide resolved

ibgreen force-pushed the ib/gltf-parse branch from ad20bfb to 39b69b3 Compare September 20, 2019 15:10

Ib Green added 2 commits September 20, 2019 08:11

gltf: gltf-loader waits until all assets loaded.

ab8feb8

linter

bdea4fc

ibgreen force-pushed the ib/gltf-parse branch from 39b69b3 to bdea4fc Compare September 20, 2019 15:13

Ib Green added 3 commits September 20, 2019 11:13

Better error message in `selectLoader

00a44b3

fix

6de3d88

wip

3976eac

ibgreen force-pushed the ib/gltf-parse branch from 21a217b to 3976eac Compare September 20, 2019 18:53

xintongxia merged commit b9a65ab into master Sep 20, 2019

xintongxia deleted the ib/gltf-parse branch September 20, 2019 19:13

Provide feedback