Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Separate "binary image" and "parsed image" APIs #459

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Sep 29, 2019

  • Provide a minimal API for extracting type, dimensions, data from loaded images regardless of the type actually loaded (ImageBitmap, Image, ndarray).
  • Rename the existing API for inspecting raw binary images to BinaryImage...

@coveralls
Copy link

coveralls commented Sep 29, 2019

Coverage Status

Coverage decreased (-0.9%) to 57.784% when pulling 53fa268 on ib/binary-vs-parsed-image-api into fc083a5 on master.

@@ -1,5 +1,6 @@
/* global self, Image, Blob */

/* global self, Image, Blob */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove, duplicate

case 'html':
/* global document */
const canvas = document.createElement('canvas');
const context = canvas.getContext('2d');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we reuse the canvas?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO.

@ibgreen ibgreen force-pushed the ib/binary-vs-parsed-image-api branch from 0405566 to ce9526a Compare September 30, 2019 19:49
@ibgreen ibgreen merged commit bb99180 into master Sep 30, 2019
@ibgreen ibgreen deleted the ib/binary-vs-parsed-image-api branch September 30, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants