Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load when using auto loader detection #559

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Fix load when using auto loader detection #559

merged 1 commit into from
Dec 13, 2019

Conversation

Pessimistress
Copy link
Collaborator

parse is confused about incoming arguments when loaders is null (happens when calling load(url, options)).

Add a unit test.

@coveralls
Copy link

coveralls commented Dec 13, 2019 •
edited
Loading

Coverage Status

Coverage increased (+3.4%) to 49.394% when pulling 59f5b08 on x/load-bug into b738d77 on master.

@Pessimistress Pessimistress merged commit d7be10f into master Dec 13, 2019
@Pessimistress Pessimistress deleted the x/load-bug branch December 13, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@xintongxia xintongxia Awaiting requested review from xintongxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @ibgreen