Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@loaders.gl/3d-tiles: Port DoublyLinkedList test from Cesium #627

Merged
merged 1 commit into from
Jan 16, 2020
Merged

@loaders.gl/3d-tiles: Port DoublyLinkedList test from Cesium #627

merged 1 commit into from
Jan 16, 2020

Conversation

xintongxia
Copy link

  • port test file
  • fix linked list counter

@coveralls
Copy link

coveralls commented Jan 16, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-2.8%) to 51.6% when pulling dfbc007 on xx/linked-list-test into 929630c on master.

ibgreen
ibgreen approved these changes Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A doubly linked list does not seem to be among the most common data structure in JS - I am not even sure I have seen a JS implementation before.
  • Looking forward to see your use case for this class.

@xintongxia
Copy link
Author

  • A doubly linked list does not seem to be among the most common data structure in JS - I am not even sure I have seen a JS implementation before.
  • Looking forward to see your use case for this class.

It has been used in Tile3DCache and thus part of the Traversal.

@xintongxia xintongxia merged commit 4e1b5b4 into master Jan 16, 2020
@xintongxia xintongxia deleted the xx/linked-list-test branch January 16, 2020 16:44
MarcusSorealheis
MarcusSorealheis reviewed Jan 17, 2020
View reviewed changes
Copy link

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusSorealheis MarcusSorealheis MarcusSorealheis left review comments

@ibgreen ibgreen ibgreen approved these changes

@loshjawrence loshjawrence Awaiting requested review from loshjawrence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xintongxia @coveralls @MarcusSorealheis @ibgreen