This repository has been archived by the owner on May 14, 2019. It is now read-only.
Run only fusion-apollo-universal-client tests in node #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currenty a handful of jest bugs when it comes to symlinks and our monorepo construction not working well together. Run tests only in node until there's upstream jest fixes or we refactor our monorepo construction.
KevinGrandon
commented
Jan 10, 2019
.buildkite/verification.yml
Outdated
| - name: 'fusion-apollo-universal-client test' | ||
| # Temporarily only run node env tests. | ||
| # There are some symlink issues resolving javascript files with the current monorepo construction. | ||
| command: './node_modules/.bin/lerna exec --scope fusion-apollo-universal-client yarn test --env node' |
There was a problem hiding this comment.
Only relevant change, rest is prettier I guess.
KevinGrandon
changed the title
|
Going to just merge this to fix release verification, but feel free to audit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currenty a handful of jest bugs when it comes to symlinks and our monorepo construction not working well together. Run tests only in node until there's upstream jest fixes or we refactor our monorepo construction. For some reasons this only occurs when these tests are run in the jsdom environment.