Avoid suggesting castToNonNull fixes in certain cases #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #1182
💛 - Coveralls |
|
Tested this more and didn't see any weird crashes or unexpected behaviors, so I think it's ready for review. |
lazaroclapp
reviewed
Aug 22, 2023
| " return castToNonNull(o);", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void suppressInsteadOfCastToNonNull() throws IOException { |
There was a problem hiding this comment.
Minor comment noting which cases these are and referencing the ErrorBuilder docs? Just because when not seen as part of the PR it might be hard to remember why we want this behavior.
Also, can we add a case where null is assigned to a non-null field?
|
@lazaroclapp addressed your comments and also added a few more tests for |
lazaroclapp
approved these changes
Aug 25, 2023
Co-authored-by: Lázaro Clapp <lazaro@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid suggesting a
castToNonNullfix if either (1) the expression is thenullliteral (i.e., don't suggestcastToNonNull(null)), or (2) the expression is a@Nullableparameter (see code comments for justification). In these cases, we suggest a@SuppressWarningsannotation instead.Here we also add some tests to improve coverage of the
ErrorBuilderclass.