Modify JMH Benchmark Workflow For Shellcheck #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
reviewed
Aug 21, 2023
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
msridhar
requested changes
Aug 21, 2023
| @@ -1,9 +1,9 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cd $BRANCH_NAME/ | |||
| cd "$BRANCH_NAME/" || exit | |||
There was a problem hiding this comment.
For all these cases of || exit I'm concerned that if the command ever fails (which I don't expect) it will be very difficult to diagnose. Does shellcheck still complain about the missing || exit if you do #!/bin/bash -eux at the beginning of the scripts?
There was a problem hiding this comment.
Using -eux is probably a better way to do it for our case. Updated accordingly
|
BTW, a general tip with git is to make changes in your fork on a branch other than |
Co-authored-by: Manu Sridharan <msridhar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Shellcheck errors for JMH workflow files.