-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for collect()
in Streams API
#933
Comments
Hrm, I can't repro using NullAway's default settings. Here's my version: msridhar/nullaway-java-sample@d54b686 Can you share what settings you are using? |
Hi @msridhar, I am not able to reproduce the issue in your environment, however I did miss a detail about a function call within a collect lambda that might be a different issue. I am still having the original issue in my env. https://github.com/jdcaperon/nullaway-java-sample/pull/1/files As for the original issue, which is still failing in my environment.
Let me get back to you on this I might be able to repro in your env with our settings. Version: 0.10.24 Do you want all ErrorProne settings or just the NullAway ones?
Given it's not reproducable on the default I can try changing settings until it works on my end 👍 |
Ok, thanks, @jdcaperon! Please report back if you have other use cases, and we can look into them. |
How hard would it be to support nullability within stream reducers such as
collect()
?https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html#collect-java.util.stream.Collector-
I had a look at how I might support this in the existing model but I think this would require supporting a new kind of method class (reductions) on streaming models. Understandably this might be a bit hard...
The text was updated successfully, but these errors were encountered: