Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base docker and examples throws error at data ingest "panic: Missing primary key column" #147

Closed
shaunstoltz opened this issue Apr 26, 2019 · 4 comments
Assignees

Comments

@shaunstoltz
Copy link

shaunstoltz commented Apr 26, 2019

Describe the bug
A clear and concise description of what the bug is.
Running basic docker and examples throws error:
panic: Missing primary key column

To Reproduce
Steps to reproduce the behavior:
Follow docker instructions
Follow example instructions inside docker container

Expected behavior
A clear and concise description of what you expected to happen.
Be able to run examples in docker container, so I can get to a place where I can query data via swagger interface. Would also be useful to have a plain description of how to get data ingested via swagger interface as trying to dig through go code inside a docker container to trouble shoot is cumbersome.

Full details=============
s@a:$ sudo nvidia-docker run -p 9374:9374/tcp -p 43202:43202/tcp -it aresdb:latest
[sudo] password for s:
root@020b4c0afe0a:/go/src/github.com/uber/aresdb# make run_server >> ./log/aresdb.log 2>&1 &
[1] 15
root@020b4c0afe0a:/go/src/github.com/uber/aresdb# cd examples/
root@020b4c0afe0a:/go/src/github.com/uber/aresdb/examples# go build examples.go
root@020b4c0afe0a:/go/src/github.com/uber/aresdb/examples# ./examples tables --dataset 1k_trips
table cities created
table trips created
root@020b4c0afe0a:/go/src/github.com/uber/aresdb/examples# ./examples data --dataset 1k_trips
panic: Missing primary key column
goroutine 1 [running]:
github.com/uber/aresdb/utils.StackError(0x0, 0x0, 0x8f01c9, 0x1a, 0x0, 0x0, 0x0, 0x0)
/root/go/src/github.com/uber/aresdb/utils/error.go:61 +0x46e
github.com/uber/aresdb/client.checkPrimaryKeys(0xc42033a140, 0xc420316ce0, 0x2, 0x2, 0x0, 0x0)
/root/go/src/github.com/uber/aresdb/client/connector.go:241 +0x14b
github.com/uber/aresdb/client.(*connector).prepareUpsertBatch(0xc42026c9a0, 0xc4200149f0, 0x6, 0xc420316ce0, 0x2, 0x2, 0xc420018fb0, 0x2, 0x2, 0xc4203a6000, ...)
/root/go/src/github.com/uber/aresdb/client/connector.go:223 +0xae
github.com/uber/aresdb/client.(*connector).Insert(0xc42026c9a0, 0xc4200149f0, 0x6, 0xc420316ce0, 0x2, 0x2, 0xc4203a6000, 0xa, 0x10, 0x0, ...)
/root/go/src/github.com/uber/aresdb/client/connector.go:169 +0x247
main.ingestDataForTable(0xb3b020, 0xc42026c9a0, 0xc4200149f0, 0x6, 0xc420014d00, 0x1a)
/root/go/src/github.com/uber/aresdb/examples/examples.go:187 +0x961
main.ingestDataForDataSet()
/root/go/src/github.com/uber/aresdb/examples/examples.go:115 +0x370
main.main.func1(0xc4200af900, 0xc420316740, 0x0, 0x2)
/root/go/src/github.com/uber/aresdb/examples/examples.go:214 +0x20
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).execute(0xc4200af900, 0xc4203166e0, 0x2, 0x2, 0xc4200af900, 0xc4203166e0)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:766 +0x2c1
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4200af680, 0x8e1260, 0xc4200af7d0, 0xc42014df68)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:852 +0x334
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200af680, 0xc42014df58, 0x3)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:800 +0x2b
main.main()
/root/go/src/github.com/uber/aresdb/examples/examples.go:239 +0x524

goroutine 1 [running]:
main.panicIfErr(0xb3b0a0, 0xc4203193e0)
/root/go/src/github.com/uber/aresdb/examples/examples.go:67 +0x4a
main.ingestDataForTable(0xb3b020, 0xc42026c9a0, 0xc4200149f0, 0x6, 0xc420014d00, 0x1a)
/root/go/src/github.com/uber/aresdb/examples/examples.go:188 +0x986
main.ingestDataForDataSet()
/root/go/src/github.com/uber/aresdb/examples/examples.go:115 +0x370
main.main.func1(0xc4200af900, 0xc420316740, 0x0, 0x2)
/root/go/src/github.com/uber/aresdb/examples/examples.go:214 +0x20
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).execute(0xc4200af900, 0xc4203166e0, 0x2, 0x2, 0xc4200af900, 0xc4203166e0)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:766 +0x2c1
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc4200af680, 0x8e1260, 0xc4200af7d0, 0xc42014df68)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:852 +0x334
github.com/uber/aresdb/vendor/github.com/spf13/cobra.(*Command).Execute(0xc4200af680, 0xc42014df58, 0x3)
/root/go/src/github.com/uber/aresdb/vendor/github.com/spf13/cobra/command.go:800 +0x2b
main.main()
/root/go/src/github.com/uber/aresdb/examples/examples.go:239 +0x524
root@020b4c0afe0a:~/go/src/github.com/uber/aresdb/examples#

@lucafuji lucafuji self-assigned this May 14, 2019
@lucafuji
Copy link
Contributor

@shaunstoltz Thanks for reporting this. I'm taking a look.

@lucafuji
Copy link
Contributor

We found the root cause and we are going to post a fix soon.
At the meantime, we are also trying to improve our onboarding experience. .e.g using an interactive shell

@shaunstoltz
Copy link
Author

@lucafuji thanks for the update and the fix. Very interested in this project and doing a quick Go crash course so I can try contribute.

@lucafuji
Copy link
Contributor

@lucafuji thanks for the update and the fix. Very interested in this project and doing a quick Go crash course so I can try contribute.

Glad you like this project! This issue should be fixed and I'm going to close it. If you find any other issues, feel free to open another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants