Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider bundling a proguard configuration file with Android components #112

Closed
bensandee opened this issue Oct 19, 2017 · 1 comment · Fixed by #111
Closed

Consider bundling a proguard configuration file with Android components #112

bensandee opened this issue Oct 19, 2017 · 1 comment · Fixed by #111
Labels
Android

Comments

@bensandee
Copy link
Contributor

AutoDipose 0.3.0 requires something like this in my project (fwiw, 0.2.0 didn't need anything):

-dontwarn com.uber.javaxextras.FieldsMethodsAndParametersAreNonNullByDefault
@ZacSweers
Copy link
Collaborator

Good idea! I'll add it in the upcoming structured android components

ZacSweers added a commit that referenced this issue Oct 19, 2017
@ZacSweers
Add consumer proguard rules for javaxextras
4b2e28b 
Resolves #112
@ZacSweers ZacSweers mentioned this issue Oct 21, 2017
Merged
ZacSweers added a commit that referenced this issue Oct 21, 2017
@ZacSweers
Structured Android components (and some refactorings) (#111)
b8715fd 
* Move android components to /android directory

* Opportunistic update to Gradle 4.2.1

* Extract TestAndroidLifecycleScopeProvider to own module, rename

This renames TestAndroidLifecycleScopeProvider to the more appropriate TestLifecycleOwner. Amongst other things, this makes the extensions/common dependencies only part of that artifact and not a part of the mainline artifact

* Opportunistic update kotlin plugin name to newer qualified one

* Switch to static creators for TestLifecycleOwner

* Add autodispose-android-kotlin artifact

* Add autodispose-android-archcomponents-kotlin artifact

* Add autodispose-android-archcomponents-test-kotlin artifact

* arch components rc1

* Build tools 26.0.2

* Add consumer proguard rules for javaxextras

Resolves #112

* Common 1.0.3 + include in archcomponents

This is apparently necessary for generated code

* Make the test use something other than .test for name to avoid conflicts

* Remove manifest, set in defaultConfig instead

* Ignore restricted API warning in generated adapter code

* Add generated adapter to proguard rules in case

* Add convenience Function<Lifecycle.Event, Lifecycle.Event> resolver API

This also simplifies the multiple constructors we had going on

* Update stop check to match slinky behavior

Due to a behavior change, stop events just mean it falls back to "created", which presumably could restart. To match this, I've changed the test to measure this such that if the last even was pause, we don't assume destroy, and actually just stop in onStop like normal

* Remove backfilling from TestLifecycleOwner, as registry handles it now
@ZacSweers ZacSweers mentioned this issue Oct 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Structured Android components (and some refactorings) uber/AutoDispose
2 participants
@bensandee @ZacSweers