Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demo scope provider for Fragment #37

Closed
tonycosentini opened this issue Feb 8, 2017 · 4 comments
Closed

Add demo scope provider for Fragment #37

tonycosentini opened this issue Feb 8, 2017 · 4 comments
Labels
Android Discussion

Comments

@tonycosentini
Copy link
Contributor

No description provided.

@ZacSweers
Copy link
Collaborator

ZacSweers commented Mar 2, 2017 •
edited

I think we should provide some examples of how to hook one up, but I don't think we should ship something first party. Especially with support library variants out there, kind of makes a mess and most people just implement it in their own base classes I think. Can revisit if Android APIs improve in the future for external observation.

@ZacSweers ZacSweers changed the title Add scope provider for Fragment Add demo scope provider for Fragment Mar 2, 2017
@tadfisher
Copy link

FragmentLifecycleCallbacks exists for the support library.

@ZacSweers
Copy link
Collaborator

Same issues as #36 (comment) I think, but I'm not too familiar with the fragment callbacks. Is there a way to query the current state?

@ZacSweers ZacSweers mentioned this issue May 24, 2017
Merged
@djkovrik djkovrik mentioned this issue Sep 10, 2017
Closed
@ZacSweers
Copy link
Collaborator

Closing in favor of #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tonycosentini @tadfisher @ZacSweers