Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test module. #45

Closed
tonycosentini opened this issue Mar 10, 2017 · 7 comments
Closed

Add a test module. #45

tonycosentini opened this issue Mar 10, 2017 · 7 comments
Assignees
@tonycosentini
Labels
Discussion Enhancement
Milestone
0.2.0

Comments

@tonycosentini
Copy link
Contributor

Ideally, it should be easy to create ScopeProvider and LifecycleScopeProvider instances for testing.

They should:

  • Discourage mocking (mocking LifecycleScopeProvider is particularly fragile).
  • Make it simple to vend out test instances that are easy to start/stop.
@tonycosentini tonycosentini self-assigned this Mar 10, 2017
@ZacSweers
Copy link
Collaborator

ZacSweers commented Mar 10, 2017 •
edited

Should we make a released test artifact or just add them in the testing tools for reference if anyone wants them (sort of like RxErrorsRule?)

@tonycosentini
Copy link
Contributor Author

I think it's generic / useful enough to warrant a separate artifact.

@ZacSweers
Copy link
Collaborator

👍

@tonycosentini
Copy link
Contributor Author

What should the API look like?

I'm thinking:
TestLifecycleScopeProvider#start()
TestLifecycleScopeProvider#stop()
TestScopeProvider#emit()

Any thoughts?

@ZacSweers
Copy link
Collaborator

Would start and stop be lifecycle boundaries?

@tonycosentini
Copy link
Contributor Author

Yeah, so subscribing before start or after stop would throw the expected exceptions.

@tonycosentini tonycosentini mentioned this issue Mar 13, 2017
Merged
@ZacSweers
Copy link
Collaborator

Started in #48

@ZacSweers ZacSweers added this to the 0.2.0 milestone Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonycosentini tonycosentini

Labels
Discussion Enhancement
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@tonycosentini @ZacSweers