-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LifecycleEndException handling #52
Comments
What about just advising people to potentially non-fatal them in their own |
I can't think of a reason this wouldn't be fine. It was good enough for us? Do other companies implement |
After syncing with @hzsweers in person, one idea is a plugin system for AutoDispose itself. The default implementation would just route to onError like it does currently, but would allow for custom handlers (for logging/non-fatals or whatever else makes sense for a specific app). |
Cool, plugin system sounds good. @tonycosentini do you want to start a PR around that? Structure would probably be best in the same vein as |
Yup, will give it a shot. |
Done in #57 |
Specifically, some might want to just dispose quietly (in production, or always) rather than error. Should we make this more configurable? If so, how/to what degree? Moving this discussion here from an internal one.
Currently -
LifecycleEndException
is propagated to the delegate observer'sonError
. I see two options:A. If the delegate doesn't implement
onError
, it goes toRxJavaPlugins
and one could filter that in a plugin hook. This would not cover cases whereonError
is implemented though. Is this fine?B. We make this more explicitly configurable
RxJavaPlugins
-esque plugin system?ScopeProvider
implementation usingScopeUtils
?CC @tonycosentini @AttwellBrian
The text was updated successfully, but these errors were encountered: