Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StickyTTL should based on LastDecisionCompletedTimestamp #2357

Closed
longquanzheng opened this issue Aug 7, 2019 · 1 comment
Closed

StickyTTL should based on LastDecisionCompletedTimestamp #2357

longquanzheng opened this issue Aug 7, 2019 · 1 comment
Labels
refactoring Code refactoring

Comments

@longquanzheng
Copy link
Collaborator

Right now we took a shot-cut to use LastUpdateTimestamp. It is inacurate. In some case we may update mutableState without any decision(ex. ActivityHeartbeat). In that case, updating LastUpdateTimestamp will make the StickyTTL not expire. It could be a bug if a customer relying on StickyTTL to dispatch tasks.
@longquanzheng longquanzheng added the refactoring Code refactoring label Aug 7, 2019
@longquanzheng longquanzheng mentioned this issue Aug 7, 2019
Merged
@longquanzheng
Copy link
Collaborator Author

longquanzheng commented Dec 30, 2019 •
edited

I think this's still valid if we still have stickTTL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longquanzheng @andrewjdawson2016