Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SearchForOneClosedExecution in ElasticSearch.GenericClient interface #3682

Open
longquanzheng opened this issue Oct 22, 2020 · 0 comments
Open

Remove SearchForOneClosedExecution in ElasticSearch.GenericClient interface #3682

longquanzheng opened this issue Oct 22, 2020 · 0 comments
Labels
refactoring Code refactoring

Comments

@longquanzheng
Copy link
Collaborator

There is a historical reason that we have it. And it was too risky to remove it in the refactor PR #3666

Technically it's possible to just use SearchByQuery for the purpose, as SearchByQuery is more generic.
@longquanzheng longquanzheng added the refactoring Code refactoring label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@longquanzheng